Closed
Bug 304982
Opened 19 years ago
Closed 19 years ago
CPP_THROW_NEW should be defined to throw() even if exceptions are enabled
Categories
(Firefox Build System :: General, defect, P2)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
774 bytes,
patch
|
benjamin
:
review+
dbaron
:
superreview+
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Our operator new implementations are still returning null instead of throwing an exception when exceptions are enabled. So the macro should be defined as throw() even with --enable-cpp-exceptions.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #192954 -
Flags: review?(benjamin)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.9alpha
Updated•19 years ago
|
Attachment #192954 -
Flags: superreview?(dbaron)
Attachment #192954 -
Flags: review?(benjamin)
Attachment #192954 -
Flags: review+
Attachment #192954 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 2•19 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1508; previous revision: 1.1507 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 192954 [details] [diff] [review] patch OK, this annoyed me on the 1.8 branch today, would be nice to have it there too.
Attachment #192954 -
Flags: approval-branch-1.8.1?(benjamin)
Updated•18 years ago
|
Attachment #192954 -
Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
Assignee | ||
Comment 4•18 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1503.2.81; previous revision: 1.1503.2.80 done
Keywords: fixed1.8.1
Assignee | ||
Updated•18 years ago
|
Target Milestone: mozilla1.9alpha → mozilla1.8.1
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•