Closed Bug 304987 Opened 19 years ago Closed 19 years ago

L10N installer creates shortcuts with $ProductName$ name

Categories

(Firefox :: Installer, defect, P1)

Product:
Firefox
Component:
Installer
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: unghost, Assigned: benjamin)

References

Details

(Keywords: fixed1.8, Whiteboard: landed on trunk, waiting a day for the branch)

Attachments

(1 file)

Use makejs.pl and fix some $UserAgent$ issues in config.ini
60.82 KB, patch
chase
: review+
mscott
: approval1.8b4+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b4) Gecko/20050816 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b4) Gecko/20050816 Firefox/1.0+

Russian installer for Win32 branch builds (builds from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8-l10n/)
is creating shortcuts with names like $ProductName$.
I've got 3 wrong shortcuts in total:
2 in Start menu: $ProductName$ and $ProductName$ (Safe Mode) and 1 on Desktop:
$ProductName$ 

Shortcuts' target is "C:\Program Files\Mozilla Firefox\$MainExeFile$" instead
"C:\Program Files\Mozilla Firefox\firefox.exe"

Also I've got in registry this folder -
HKEY_CURRENT_USER\Software\Mozilla\$ProductName$ $UserAgentShort$

This problem doesn't affect en-US build.

Reproducible: Always

Steps to Reproduce:
1.Install localized Firefox installer
2.
3.

Actual Results:  
Got wrong shortcuts with wrong names

Expected Results:  
Should get right shortcuts
Assignee: nobody → benjamin
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking1.8b4+
Whiteboard: ETA 8/23
Blocks: 301702
Whiteboard: ETA 8/23 → has patch, needs review (Chase)
Flags: blocking1.8b5+
Priority: -- → P1
Target Milestone: --- → Firefox1.5
Attachment #193450 - Flags: review?(chase) → review+
Whiteboard: has patch, needs review (Chase) → has patch, Chase has reviewed
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: has patch, Chase has reviewed → landed on trunk, waiting a day for the branch
Attachment #193450 - Flags: approval1.8b4?
Comment on attachment 193450 [details] [diff] [review]
Use makejs.pl and fix some $UserAgent$ issues in config.ini

I verified today's trunk Thunderbird installer. Asa did the same for the
Firefox installer. Per the triage meeting today, plussing for the branch.
Attachment #193450 - Flags: approval1.8b4? → approval1.8b4+
Keywords: fixed1.8
Fixed on 1.8 branch.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: