305019 - crmf: CRMFPOPOSigningKeyInputTemplate does not match to underlying structure

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Alexei Volkov]

here is one more template:
 
 
It from nss/lib/crmf/crmftmpl.c: 173
 
const SEC_ASN1Template CRMFPOPOSigningKeyInputTemplate[] = {
    { SEC_ASN1_SEQUENCE, 0, NULL,sizeof(CRMFPOPOSigningKeyInput) },
    { SEC_ASN1_OPTIONAL | SEC_ASN1_CONSTRUCTED |
      SEC_ASN1_CONTEXT_SPECIFIC | 0,
      offsetof(CRMFPOPOSigningKeyInput, authInfo.sender) },
    { SEC_ASN1_BIT_STRING | SEC_ASN1_OPTIONAL | 1,
      offsetof (CRMFPOPOSigningKeyInput, authInfo.publicKeyMAC) },
    { SEC_ASN1_INLINE | SEC_ASN1_XTRN,
      offsetof(CRMFPOPOSigningKeyInput, publicKey),
      SEC_ASN1_SUB(CERT_SubjectPublicKeyInfoTemplate) },
    { 0 }
};
 
 
The corresponded structure is located at
 
nss/lib/crmf/crmfit.h:164
 
struct CRMFPOPOSigningKeyInputStr {
    /* ASN1 must have only one of the next 2 options */
    union {
        SECItem          sender; /*General Name*/
        CRMFPKMACValue  *publicKeyMAC;
    }authInfo;
    CERTSubjectPublicKeyInfo publicKey;
};

This template and so is the structure is not used throughout the code. I'm
puting this bug for the record to keep track of incorrect templates in nss.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Adding Bob to ASN.1 encoder/decoder related bugs

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

http://lxr.mozilla.org/security/search?string=CRMFPOPOSigningKeyInput
shows that the template is dead code.  Let's just delete it from the source.
The struct that goes with it seems to be used in some places, but maybe
they're all dead code?

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.