305042 - Plugin Finder Service allows Next button before download complete

Status: RESOLVED INVALID

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[James Crowe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

While doanloading a plugin the Finder Service has an enabled "Next >" button.
When Next button clicked before download is complete the download is canceled
but Finder continues to next form claiming installation is complete.

Reproducible: Always

Steps to Reproduce:
1.Click on "Click here to download plugin." area in browser window of webpage
needing plugin.
2.Click "Next" after Pluging Finder selects plugin needed.
3.Click "Next" before download is complete.

Actual Results:  
Plugin Finder continues to next form.

Expected Results:  
Not have "next" button enabled until download is complete.

Comment 1

[b]

While downloading a plugin on the latest Firefox release, you can click next
while the plugin is still downloading.  This skips the install yet lets the user
know that the component was installed successfully.  Meanwhile, the install
truly has failed and is not just laying around in the background somewhere.

firefox 1.0.7
gecko 20050915

Comment 2

[Hrishikesh Barua]

This is a serious problem when you're trying to get users to run an applet and they don't have Java. It defeats the whole purpose of the auto-download-and-install feature of the plugin. Normal (read non techie) users cannot be expected to figure out that the installation was not successful - the maximum that can be expected of them is to click every 'Next' button.

Comment 3

[Hrishikesh Barua]

Have investigated this a little. 
The problem seems to be when the plugin does not have a license agreement URL. 
The Java plugin has two parts - a small exe which is downloaded first, and  which downloads the actual JRE. Since the JRE displays a license agreement later on that might be a reason for not having a license page in the PFS.

Due to this, in content\mozapps\plugins\pluginInstallerWizard.js (in toolkit.jar)

nsPluginInstallerWizard.prototype.showLicenses = function (){
.....
if (this.mPluginLicenseArray.length == 0) {
    // no plugins require licenses  
===>this.advancePage(null, true, false, false);
  } else {
    this.licenseAcceptCounter = 0;
    document.getElementById("licenseIFrame").contentWindow.addEventListener("load", gPluginInstaller.enableNext, false);
    this.showLicense();
  }
.....
.....
In advancePage(null, true, false, false), the second param specifies whether to show the Next button or not. It should be false in this case. 
I've tested this with Firefox 1.0, 1.5 and 2.0 with plugins which show a license  on the PFS page (like Macromedia Shockwave) and which do not (Java). If I've not missed anything and this won't affect other functionality I can commit this.

Comment 4

[Hrishikesh Barua]

Attachment: pluginInstallerWizard.js with the Next button fix for Java plugin

Comment 5

[Hrishikesh Barua]

Oops forgot to mention - the attachment https://bugzilla.mozilla.org/attachment.cgi?id=284837 is for Firefox 2.0.0.4

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 284837 [details] [diff] [review]
pluginInstallerWizard.js with the Next button fix for Java plugin

That's not a patch, it looks like a binary. Also, I'm not the module owner or a peer for pluginInstallerWizard. Try the form at http://www.mozilla.org/owners.html to find in which module a source file you are patching lives.

/be

Comment 7

[Doron Rosenberg (IBM)]

Comment on attachment 284837 [details] [diff] [review]
pluginInstallerWizard.js with the Next button fix for Java plugin

not a patch

Comment 8

[Hrishikesh Barua]

Apologies - it was a zip file. Attaching the pluginInstallerWizard.js file as it is this time.
Brendan, thanks for the pointer - however on http://www.mozilla.org/owners.html 'Plugins' module was the nearest I could get to determining which module this would belong to.

Comment 9

[Hrishikesh Barua]

Attachment: pluginInstallerWizard.js

Comment 10

[Benjamin Smedberg]

Comment on attachment 286115 [details] [diff] [review]
pluginInstallerWizard.js

That's still not a patch; redirecting review to doron who is the module owner of PFS.

Comment 11

[Kevin Brosnan]

Just in case the submitter does not know what is expected read  http://developer.mozilla.org/en/docs/Creating_a_patch

Comment 12

[Hrishikesh Barua]

Attachment: pluginInstallerWizard.js

I hope I've done it right this time.

Comment 13

[Hrishikesh Barua]

Thanks Kevin - I should have read that first.

Comment 14

[Doron Rosenberg (IBM)]

So any plug-in (such as flash) shows this?

Also, what branch did you diff this against?

I won't get to this untill mid-week probably as my boxes are all in transit.

Comment 15

[Hrishikesh Barua]

I've tested this with plugins which show a license on the PFS page (like Shockwave) and ones which do not (Java). It works in both cases.
The diff is against the cvs tag FIREFOX_2_0_0_7_RELEASE.
Hope this helps.

Comment 16

[Hrishikesh Barua]

Hello! I know reviews take time, but is there any way of knowing the current status? Thanks.

Comment 17

[Doron Rosenberg (IBM)]

(In reply to comment #16)
> Hello! I know reviews take time, but is there any way of knowing the current
> status? Thanks.
> 

Did you make sure to test mixed situations (one license and one non-license) where multiple plugins are installed at the same time?

My windows build system is broke, and since java only works on windows, I can only test this once I get that system building again.

Comment 18

[Hrishikesh Barua]

Apologies for the late reply. 
To tell you the truth, I could not find any Firefox plugins which depend on another plugin (so that I can install them at the same time) - assuming that this is the only way of installing multiple plugins simultaneously (If any others please let me know). 
Any pointers on this?

Comment 19

[Doron Rosenberg (IBM)]

Just have a page with two missing plugins (flash and say java) - it will install both

Comment 20

[Hrishikesh Barua]

Thanks. I tried with what you suggested. It works fine - as in the installation for both plugins proceeds as they would individually. The license page for the Flash plugin comes up, and after it's installed the Java plugin start downloading, and the next button is disabled till it completes. 

Comment 21

[Hrishikesh Barua]

Hello! Will this go in into any of the near future releases? 
Thanks.