Plugin Finder Service allows Next button before download complete



Toolkit Graveyard
Plugin Finder Service
13 years ago
4 years ago


(Reporter: James Crowe, Unassigned)




(1 attachment, 2 obsolete attachments)



13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+

While doanloading a plugin the Finder Service has an enabled "Next >" button.
When Next button clicked before download is complete the download is canceled
but Finder continues to next form claiming installation is complete.

Reproducible: Always

Steps to Reproduce:
1.Click on "Click here to download plugin." area in browser window of webpage
needing plugin.
2.Click "Next" after Pluging Finder selects plugin needed.
3.Click "Next" before download is complete.

Actual Results:  
Plugin Finder continues to next form.

Expected Results:  
Not have "next" button enabled until download is complete.

Comment 1

13 years ago
While downloading a plugin on the latest Firefox release, you can click next
while the plugin is still downloading.  This skips the install yet lets the user
know that the component was installed successfully.  Meanwhile, the install
truly has failed and is not just laying around in the background somewhere.

firefox 1.0.7
gecko 20050915

Comment 2

11 years ago
This is a serious problem when you're trying to get users to run an applet and they don't have Java. It defeats the whole purpose of the auto-download-and-install feature of the plugin. Normal (read non techie) users cannot be expected to figure out that the installation was not successful - the maximum that can be expected of them is to click every 'Next' button.

Comment 3

11 years ago
Have investigated this a little. 
The problem seems to be when the plugin does not have a license agreement URL. 
The Java plugin has two parts - a small exe which is downloaded first, and  which downloads the actual JRE. Since the JRE displays a license agreement later on that might be a reason for not having a license page in the PFS.

Due to this, in content\mozapps\plugins\pluginInstallerWizard.js (in toolkit.jar)

nsPluginInstallerWizard.prototype.showLicenses = function (){
if (this.mPluginLicenseArray.length == 0) {
    // no plugins require licenses  
===>this.advancePage(null, true, false, false);
  } else {
    this.licenseAcceptCounter = 0;
    document.getElementById("licenseIFrame").contentWindow.addEventListener("load", gPluginInstaller.enableNext, false);
In advancePage(null, true, false, false), the second param specifies whether to show the Next button or not. It should be false in this case. 
I've tested this with Firefox 1.0, 1.5 and 2.0 with plugins which show a license  on the PFS page (like Macromedia Shockwave) and which do not (Java). If I've not missed anything and this won't affect other functionality I can commit this.

Comment 4

11 years ago
Created attachment 284837 [details] [diff] [review]
pluginInstallerWizard.js with the Next button fix for Java plugin
Attachment #284837 - Flags: review?(brendan)

Comment 5

11 years ago
Oops forgot to mention - the attachment is for Firefox
Comment on attachment 284837 [details] [diff] [review]
pluginInstallerWizard.js with the Next button fix for Java plugin

That's not a patch, it looks like a binary. Also, I'm not the module owner or a peer for pluginInstallerWizard. Try the form at to find in which module a source file you are patching lives.

Attachment #284837 - Flags: review?(brendan)

Comment 7

11 years ago
Comment on attachment 284837 [details] [diff] [review]
pluginInstallerWizard.js with the Next button fix for Java plugin

not a patch
Attachment #284837 - Attachment is obsolete: true

Comment 8

11 years ago
Apologies - it was a zip file. Attaching the pluginInstallerWizard.js file as it is this time.
Brendan, thanks for the pointer - however on 'Plugins' module was the nearest I could get to determining which module this would belong to.

Comment 9

11 years ago
Created attachment 286115 [details] [diff] [review]
Attachment #286115 - Flags: review?(benjamin)

Comment 10

11 years ago
Comment on attachment 286115 [details] [diff] [review]

That's still not a patch; redirecting review to doron who is the module owner of PFS.
Attachment #286115 - Flags: review?(benjamin) → review?(doronr)

Comment 11

11 years ago
Just in case the submitter does not know what is expected read

Comment 12

11 years ago
Created attachment 286386 [details] [diff] [review]

I hope I've done it right this time.
Attachment #286115 - Attachment is obsolete: true
Attachment #286386 - Flags: review?(doronr)
Attachment #286115 - Flags: review?(doronr)

Comment 13

11 years ago
Thanks Kevin - I should have read that first.
So any plug-in (such as flash) shows this?

Also, what branch did you diff this against?

I won't get to this untill mid-week probably as my boxes are all in transit.

Comment 15

11 years ago
I've tested this with plugins which show a license on the PFS page (like Shockwave) and ones which do not (Java). It works in both cases.
The diff is against the cvs tag FIREFOX_2_0_0_7_RELEASE.
Hope this helps.

Comment 16

11 years ago
Hello! I know reviews take time, but is there any way of knowing the current status? Thanks.
(In reply to comment #16)
> Hello! I know reviews take time, but is there any way of knowing the current
> status? Thanks.

Did you make sure to test mixed situations (one license and one non-license) where multiple plugins are installed at the same time?

My windows build system is broke, and since java only works on windows, I can only test this once I get that system building again.

Comment 18

10 years ago
Apologies for the late reply. 
To tell you the truth, I could not find any Firefox plugins which depend on another plugin (so that I can install them at the same time) - assuming that this is the only way of installing multiple plugins simultaneously (If any others please let me know). 
Any pointers on this?
Just have a page with two missing plugins (flash and say java) - it will install both

Comment 20

10 years ago
Thanks. I tried with what you suggested. It works fine - as in the installation for both plugins proceeds as they would individually. The license page for the Flash plugin comes up, and after it's installed the Java plugin start downloading, and the next button is disabled till it completes. 

Comment 21

10 years ago
Hello! Will this go in into any of the near future releases? 


10 years ago
Product: Firefox → Toolkit


4 years ago
Attachment #286386 - Flags: review?(doronr) → review-


4 years ago
Last Resolved: 4 years ago
Resolution: --- → INVALID


4 years ago
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.