Closed Bug 305047 Opened 19 years ago Closed 19 years ago

configure.in uses and misuses '[' and ']'

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: daa, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

-u12 vserion of patch
6.71 KB, patch
cls
: review+
Details | Diff | Splinter Review 
configure.in uses [[ and ]] to escape [ and ] in some places 
uses changequote(,) and changequote([,]) in others and
does not quote at all in still others

patch converts all to use changequote(,) and changequote([,])
Attached patch configure.in patch (obsolete) — — Splinter Review 

    
    

    
  
timeless@ did a related checkin a few days ago, maybe he can review...
Summary: configure.in uses and misuses  '[' and ']' → configure.in uses and misuses  '[' and ']'

    
    

    
  
Could you please provide this patch as -u12? It is much easier to review that way.

    
    

    
  


  

        Attachment #193016 -
        Attachment is obsolete: true

    
  

        Attachment #193078 -
        Flags: review?(cls)

    
  

        Attachment #193078 -
        Flags: review?(cls) → review+

    
  
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: