Closed Bug 30511 Opened 25 years ago Closed 24 years ago

[feature] [XUL] Convert <tree> to <grid>

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

(Keywords: perf, Whiteboard: [nsbeta2+] Estimate landing on 6/19)

Attachments

(4 files)

treeBindings.xml
3.22 KB, patch
Details | Diff | Splinter Review
diff in layout/xul/base
9.03 KB, patch
Details | Diff | Splinter Review
new patch for treeBindings.xml
3.97 KB, patch
Details | Diff | Splinter Review
new patch for /mozilla/layout/xul
10.00 KB, patch
Details | Diff | Splinter Review 
When <grid> comes online, <tree> needs to be converted to it.
Status: NEW → ASSIGNED
Target Milestone: M15
Blocks: 9656
Blocks: 28226
Summary: [XUL] Convert <tree> to <grid> → [feature] [XUL] Convert <tree> to <grid>
depends on evaughan box grid landing
Whiteboard: 15 days (could split work with evaughan)
Target Milestone: M15 → M17
*** Bug 33298 has been marked as a duplicate of this bug. ***
Changing platform to all - bug #33298 was about the tree view being very slow on

Linux.
Keywords: dogfood, rtm
OS: Windows 98 → All
Hardware: PC → All
Putting on the PDT- radar for dogfood.
Whiteboard: 15 days (could split work with evaughan) → [PDT-]15 days (could split work with evaughan)
Mass moving M17 bugs to M18
Target Milestone: M17 → M18
This (the dup 33298) is a serious problem for Mailnews Linux dogfood.

Following the status whiteboard, it should be fixed by now. Can't it be fixed
earlier than M18?
Mass-moving feature bugs back to M17
Target Milestone: M18 → M17
Whoops, these features are planned for post B2, moving back to M18.  Sorry for
the excess spam.
Target Milestone: M17 → M18
trudelle, please see my comment above.
No, it can't be done prior to B2.  B2's focus is feature complete.  B3's focus 
is performance.  This is performance work... hence the M18 milestone.

This is too big & too late- I fear it.  It needs a detailed task breakdown and 
estimate, and we need to assign and schedule the work.
Whiteboard: [PDT-]15 days (could split work with evaughan) → [PDT-] 15 days (Need task breakdown and estimate)
trudelle, I hope, you don't consider cutting this bug. The Mailnews thread pane
on Linux is still *far* (by factor 20 or so) from being usable for me. Even
further (by factor 100-200 or so) from being good.
Putting on [NEED INFO] radar..waiting on tree rewrite decision.
Whiteboard: [PDT-] 15 days (Need task breakdown and estimate) → [NEED INFO] 15 days (Need task breakdown and estimate)
Putting on [dogfood-] radar.  Adding to nsbeta2 keyword.
Keywords: nsbeta2
Whiteboard: [NEED INFO] 15 days (Need task breakdown and estimate) → [dogfood-] 15 days (Need task breakdown and estimate)
5 days.  gave breakdown to trudelle, who could post it here.
Whiteboard: [dogfood-] 15 days (Need task breakdown and estimate) → [dogfood-] 5 days
Here is Hyatt's tree/grid breakdown: 

Total Parallel Time: 5 days 

evaughan (4 days) 
day 1-2: gfx scrollbar with proper overflow 
day 3: splitters in between cells for table headers 
day 4: ensure that grid can size to a fixed # of rows (for mailcompose) 

hyatt (5 days) 
day 1: keyboard navigation 
day 2: re-attach content node APIs 
day 3-4: migrate lazy instantiation code to grid-based tree (dependent on 
eric's day 1-2) 
day 5: ensure persistence of columns continues to work 

Pros: column resizing bugs will be fixed, view clipping problem will be fixed, 
the popup column collapser will be much faster,
column resizing will be smooth, scrolling speed will increase, the thumb size 
will be more accurate, decreases the risk to tables
in the product, fixes a slew of non-nsbeta2+ bugs as well as nsbeta2+ and 
dogfood bugs. 

Cons: Might introduce new bugs. 

Important to know: I have all trees up and running now on top of grid.  It 
works really well minus the remaining bugs above. 
Much of the code is migrating and is not being re-written.  This also reduces 
risk.
Keywords: perf
moving back to untargetted until we get a decision.
Target Milestone: M18 → ---
Adding one day to enable switching between implementations based on a pref.
Whiteboard: [dogfood-] 5 days → [dogfood-] 6 days
Blocks: 28244
Clayton says PDT gives this a go, despite no change in status whiteboard.
Conditions: can't land until after dogfood push ends, must include quick/easy
backout strategy, must land as a carpool.  moving to M17
Target Milestone: --- → M17
No longer blocks: 28226
[nsbeta2+]
Whiteboard: [dogfood-] 6 days → [dogfood-][nsbeta2+] 6 days
I tried new xul tree under Linux, but with no success for first time
I found out that some files are missing in Makefile:

nsXULTreeFrame.cpp
nsXULTreeCellFrame.cpp

and in nsXULTreeCellFrame.cpp on line 30 should be:
#include "nsINameSpaceManager.h"

Update.  Current open issues.

(1) Scrolling asserts and crashes on occasion.
(2) Mailnews crashes when deleting a message.
(3) Message compose textfields don't work in new tree (this is with the old
Ender.  Hopefully Ender Lite will work.  Will update as I find out).
(4) Columns cannot be resized. (Eric has fix but is on vacation.)
(5) Columns cannot yet be collapsed. (Doesn't work in current tree, so I don't 
view this as blocking landing.)
(6) Column sizes incorrect. (Eric has fix but is on vacation.)
Keywords: dogfood
Whiteboard: [dogfood-][nsbeta2+] 6 days → [nsbeta2+] Estimate landing on 6/14
also crashes with datasources

I work on scrolling with page up, page down keys (sea new attachments)

sorry for SPAM on this bug, but I didn't know that I should send patches
directly to bug owner

Jan Varga, patches attached to the bug are fine. If you want, you could combine
the diffs by issueing the diff from the highest common dir.
Jan, thanks.  Your patch has been applied and checked in!

There are many issues with mailnews that prevent any sort of landing tomorrow.  
I've busted my ass all day on this, and I'm totally exhausted, so I'm giving up 
and going home for now.

Revising landing date.  Pushing out to 6/19.
Whiteboard: [nsbeta2+] Estimate landing on 6/14 → [nsbeta2+] Estimate landing on 6/19
The mailnews issues are:

(1) Trees without a <treehead> don't work.
(2) The mailnews folder pane doesn't get click or double-click events for 
open/close of folders.  No idea why.  It's the only tree in the product that 
this happens to.
(3) Mail compose's tree has issues that only the XBL patch that JST and I are 
working on will fix.  I've had to spend time coding that up, and it's nearly 
read to go in.
(4) Threaded mode in mailnews just doesn't work.  The tree doesn't seem to 
really even go into threaded mode.
(5) If you're in threaded mode initially, the threads refuse to expand.
(6) Drag and drop doesn't work in any trees until I move it over.

Fixed. Jan, can you start sending me some of your patches via email now?  I 
fixed the bug with not being able to retrieve the row at the last index.  I have 
not applied your second patch yet.  Could you send it to me at 
hyatt@netscape.com after updating to a current tip?  Thanks!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verified fixed. Congrats, Dave.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: