Closed Bug 305184 Opened 15 years ago Closed 15 years ago

Make nsIXFormsModelElement::getInstanceDocument raise DOMException

Categories

(Core Graveyard :: XForms, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: allan, Assigned: allan)

References

()

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

Currently we return NS_ERROR_FAILURE from
nsXFormsModelElement::GetInstanceDocument(), but it should actually be a
DOMException per the spec. The "raises(DOMException)" is commented out in the
IDL, probably because the exact type of exception is unknown?

Which NS_ERROR_DOM_* should we return?
Attached patch Patch that reports an error (obsolete) — Splinter Review
While we're messing with the function, how about reporting an error to the
console?
Blocks: 326372
Blocks: 326373
Attached patch PatchSplinter Review
Returning DOM_NOT_FOUND error, and report errors.
Assignee: aaronr → allan
Attachment #193143 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #217029 - Flags: review?(aaronr)
Attachment #217029 - Flags: review?(aaronr) → review+
Attachment #217029 - Flags: review?(Olli.Pettay)
Attachment #217029 - Flags: review?(Olli.Pettay) → review+
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
Blocks: 332853
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.