The default bug view has changed. See this FAQ.

Make nsIXFormsModelElement::getInstanceDocument raise DOMException

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
8 months ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
fixed1.8.0.4, fixed1.8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
Currently we return NS_ERROR_FAILURE from
nsXFormsModelElement::GetInstanceDocument(), but it should actually be a
DOMException per the spec. The "raises(DOMException)" is commented out in the
IDL, probably because the exact type of exception is unknown?

Which NS_ERROR_DOM_* should we return?
(Assignee)

Comment 1

12 years ago
Created attachment 193143 [details] [diff] [review]
Patch that reports an error

While we're messing with the function, how about reporting an error to the
console?

Updated

11 years ago
Blocks: 326372

Updated

11 years ago
Blocks: 326373
(Assignee)

Comment 2

11 years ago
Created attachment 217029 [details] [diff] [review]
Patch

Returning DOM_NOT_FOUND error, and report errors.
Assignee: aaronr → allan
Attachment #193143 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #217029 - Flags: review?(aaronr)

Updated

11 years ago
Attachment #217029 - Flags: review?(aaronr) → review+
(Assignee)

Updated

11 years ago
Attachment #217029 - Flags: review?(Olli.Pettay)

Updated

11 years ago
Attachment #217029 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 3

11 years ago
Fixed on trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Updated

11 years ago
Blocks: 332853
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.3, fixed1.8.1
(Assignee)

Updated

11 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.