305227 - Up min/max version of XForms extension

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

Comment 1

[Doron Rosenberg (IBM)]

Attachment: 1.4 is 1.5 beta, 1.6a1 is trunk

Comment 2

[aaronr]

This bug addresses the fact that the nightly xforms.xpi no longer installs on a
nightly trunk build.

Comment 3

[aaronr]

Comment on attachment 193194 [details] [diff] [review]
1.4 is 1.5 beta, 1.6a1 is trunk

well, this gets the xforms.xpi to install, but now the browser hangs trying to
load an XForm.	Guess we'll look at that in a seperate bug once I get a chance
to debug it more.

Comment 4

[aaronr]

(In reply to comment #3)
> (From update of attachment 193194 [details] [diff] [review] [edit])
> well, this gets the xforms.xpi to install, but now the browser hangs trying to
> load an XForm.	Guess we'll look at that in a seperate bug once I get a chance
> to debug it more.
> 

The hang trying to load a form is caused by a bug introduced in XPath.  The
patch to bug 305326 will fix the hang.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 193194 [details] [diff] [review]
1.4 is 1.5 beta, 1.6a1 is trunk

I think we should have minVersion 1.4 and maxVersion 1.5 for branch, and 1.6a1
would be trunk only. Some interfaces may change so that the extension will not
stay binary compatible in both trunk and branch.

Comment 6

[Allan Beaufour]

(In reply to comment #5)
> (From update of attachment 193194 [details] [diff] [review] [edit])
> I think we should have minVersion 1.4 and maxVersion 1.5 for branch, and 1.6a1
> would be trunk only. Some interfaces may change so that the extension will not
> stay binary compatible in both trunk and branch.

Good idea. We should get a "pre-release" ready for 1.5 release, but then
continue working on trunk, occasionally trying to see/getting it to work on
branch and then manual create a new version?

Comment 7

[Allan Beaufour]

Attachment: Patch for branch

Comment 8

[aaronr]

Comment on attachment 195405 [details] [diff] [review]
Patch for branch

This is fine with me, but we need to verify with Mozilla.org whether we should
possibly have 1.5+ as max version instead of 1.5.  So what we need to know is
whether they are going to bump the version when they do 1.5.1, etc. security
releases.

Doron, please check this answer with Mozilla.org and get this patch checked in
to branch ASAP.  Thanks.

Comment 9

[Allan Beaufour]

http://developer.mozilla.org/devnews/index.php/2005/08/16/extension-version-changes/

Comment 10

[Doron Rosenberg (IBM)]

Comment on attachment 195405 [details] [diff] [review]
Patch for branch

Branch is closed right now.

What we should do is have an update.rdf somewhere on mozilla.org and reference
it in the install.rdf.	We can then do version bumping remotely.

Comment 11

[Allan Beaufour]

(In reply to comment #10)
> (From update of attachment 195405 [details] [diff] [review] [edit])
> Branch is closed right now.
> 
> What we should do is have an update.rdf somewhere on mozilla.org and reference
> it in the install.rdf.	We can then do version bumping remotely.
> 

That assumes that you can actually install the xpi. You cannot, because it is
incompatible. This needs to go in .... now.

Comment 12

[Jesse Ruderman]

*** Bug 307872 has been marked as a duplicate of this bug. ***

Comment 13

[Allan Beaufour]

Attachment: Patch for trunk

Set to 1.6a1 for trunk

Comment 14

[Allan Beaufour]

(In reply to comment #7)
> Created an attachment (id=195405) [edit]
> Patch for branch

I checked it in to branch with 1.4 -> 1.5, so the nightly builds will work
immediately.

Comment 15

[Allan Beaufour]

Checked in to trunk.

Bug 298431 actually fixes this forever. It is reviewed an approved, but is
waiting for build script changes. Doron promised to get hold of Chase.