Closed Bug 305227 Opened 15 years ago Closed 15 years ago

Up min/max version of XForms extension

Categories

(Core Graveyard :: XForms, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: doronr, Assigned: allan)

References

Details

(Keywords: fixed1.8)

Attachments

(2 files, 1 obsolete file)

 
Attached patch 1.4 is 1.5 beta, 1.6a1 is trunk (obsolete) — Splinter Review
Attachment #193194 - Flags: review?(aaronr)
This bug addresses the fact that the nightly xforms.xpi no longer installs on a
nightly trunk build.
Comment on attachment 193194 [details] [diff] [review]
1.4 is 1.5 beta, 1.6a1 is trunk

well, this gets the xforms.xpi to install, but now the browser hangs trying to
load an XForm.	Guess we'll look at that in a seperate bug once I get a chance
to debug it more.
Attachment #193194 - Flags: review?(aaronr) → review+
(In reply to comment #3)
> (From update of attachment 193194 [details] [diff] [review] [edit])
> well, this gets the xforms.xpi to install, but now the browser hangs trying to
> load an XForm.	Guess we'll look at that in a seperate bug once I get a chance
> to debug it more.
> 

The hang trying to load a form is caused by a bug introduced in XPath.  The
patch to bug 305326 will fix the hang.
Comment on attachment 193194 [details] [diff] [review]
1.4 is 1.5 beta, 1.6a1 is trunk

I think we should have minVersion 1.4 and maxVersion 1.5 for branch, and 1.6a1
would be trunk only. Some interfaces may change so that the extension will not
stay binary compatible in both trunk and branch.
(In reply to comment #5)
> (From update of attachment 193194 [details] [diff] [review] [edit])
> I think we should have minVersion 1.4 and maxVersion 1.5 for branch, and 1.6a1
> would be trunk only. Some interfaces may change so that the extension will not
> stay binary compatible in both trunk and branch.

Good idea. We should get a "pre-release" ready for 1.5 release, but then
continue working on trunk, occasionally trying to see/getting it to work on
branch and then manual create a new version?
Attached patch Patch for branchSplinter Review
Attachment #195405 - Flags: review?(aaronr)
Attachment #195405 - Flags: review?(smaug)
Comment on attachment 195405 [details] [diff] [review]
Patch for branch

This is fine with me, but we need to verify with Mozilla.org whether we should
possibly have 1.5+ as max version instead of 1.5.  So what we need to know is
whether they are going to bump the version when they do 1.5.1, etc. security
releases.

Doron, please check this answer with Mozilla.org and get this patch checked in
to branch ASAP.  Thanks.
Attachment #195405 - Flags: review?(smaug)
Attachment #195405 - Flags: review?(doronr)
Attachment #195405 - Flags: review?(aaronr)
Attachment #195405 - Flags: review+
Comment on attachment 195405 [details] [diff] [review]
Patch for branch

Branch is closed right now.

What we should do is have an update.rdf somewhere on mozilla.org and reference
it in the install.rdf.	We can then do version bumping remotely.
Attachment #195405 - Flags: review?(doronr) → review+
(In reply to comment #10)
> (From update of attachment 195405 [details] [diff] [review] [edit])
> Branch is closed right now.
> 
> What we should do is have an update.rdf somewhere on mozilla.org and reference
> it in the install.rdf.	We can then do version bumping remotely.
> 

That assumes that you can actually install the xpi. You cannot, because it is
incompatible. This needs to go in .... now.
*** Bug 307872 has been marked as a duplicate of this bug. ***
Attachment #195405 - Flags: approval1.8b5?
Attachment #195405 - Flags: approval1.8b5? → approval1.8b5+
Attached patch Patch for trunkSplinter Review
Set to 1.6a1 for trunk
Assignee: doronr → allan
Attachment #193194 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #195860 - Flags: review?(aaronr)
(In reply to comment #7)
> Created an attachment (id=195405) [edit]
> Patch for branch

I checked it in to branch with 1.4 -> 1.5, so the nightly builds will work
immediately.
Keywords: fixed1.8
Attachment #195860 - Flags: review?(aaronr) → review+
Attachment #195860 - Flags: review?(smaug)
Attachment #195860 - Flags: review?(smaug) → review+
Checked in to trunk.

Bug 298431 actually fixes this forever. It is reviewed an approved, but is
waiting for build script changes. Doron promised to get hold of Chase.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.