Change "prefs-sanitize" references to "prefs-clear-private-data"

RESOLVED FIXED in Firefox 2 alpha1

Status

Firefox Graveyard
Help Documentation
--
minor
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Jeff Walden (gone starting June 8), Assigned: Jeff Walden (gone starting June 8))

Tracking

({fixed1.8.1})

Trunk
Firefox 2 alpha1
fixed1.8.1

Details

(URL)

Attachments

(1 attachment)

3.50 KB, patch
Jeff Walden (gone starting June 8)
: review+
Benjamin Smedberg
: approval-branch-1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
There are two, and the obsolete naming makes them confusing.  I wanted to make
this change in bug 304408 but decided it made more sense to isolate changes
outside help docs to another bug.  There won't be a problem with this on trunk,
but I'm hoping I can squeeze it in on branch as well.
(Assignee)

Comment 1

12 years ago
Created attachment 193196 [details] [diff] [review]
Patch

Self-reviewing as a trivial bugfix, asking for approval...
Attachment #193196 - Flags: review+
Attachment #193196 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #193196 - Flags: approval1.8b4? → approval1.8b4+

Updated

12 years ago
Flags: blocking1.8b4+

Updated

12 years ago
Flags: blocking1.8b5+
(Assignee)

Comment 2

12 years ago
Comment on attachment 193196 [details] [diff] [review]
Patch

After more consideration, it's clear that this is a fix that doesn't do
anything except create more work for localizers, so I've only committed it to
trunk; the branch will be just fine with a slightly-less-accurate name.
Attachment #193196 - Flags: approval1.8b4+
(Assignee)

Comment 3

12 years ago
For the record, I got an r=mconnor over IRC, which I'd forgotten I needed
because the patch changes one file that isn't help-specific.

Anyway, patch checked in on trunk, so marking FIXED...

Regarding the blocking1.8bx+ flags, I tried to clear them but was told I
couldn't, so to whichever release manager comes around to follow up here, this
is not checked into the branch and will not be checked in because after thinking
about it a bit more it's not really needed there.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.6-
Version: 1.5 Branch → Trunk

Updated

12 years ago
Flags: blocking1.8b5+
Flags: blocking1.8b4+

Comment 4

12 years ago
Comment on attachment 193196 [details] [diff] [review]
Patch

This needs to be checked in before I can check in bug 306431.
Attachment #193196 - Flags: branch-1.8.1?(benjamin)

Comment 5

12 years ago
Comment on attachment 193196 [details] [diff] [review]
Patch

Steffen, any patch which touches browser/* only is automatically approved for the 1.8.1 branch.
Attachment #193196 - Flags: branch-1.8.1?(benjamin) → branch-1.8.1+

Comment 6

12 years ago
1.8 branch:
Checking in mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf,v  <--  firebird-toc.rdf
new revision: 1.34.2.9; previous revision: 1.34.2.8
done
Checking in mozilla/browser/components/preferences/sanitize.xul;
/cvsroot/mozilla/browser/components/preferences/sanitize.xul,v  <--  sanitize.xul
new revision: 1.9.2.2; previous revision: 1.9.2.1
done
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 alpha1
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.