305259 - Cannot override Camino's built in adblock list

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Torben]

Since bug 305010 landed you can no longer override the built in adblock list
through userContent.css (except turning adblock off and making your own list).

Steps to reproduce:

1. Turn adblock of in the preferences and visit the URL. Notice that there
   is a lot of text (in Norwegian).

2. Turn adblock on and shift-reload the page. Most of the text will be gone.

3. Quit Camino and add the following to your userContent.css

     div[id*="advert"] {
       display: inline !important
     }

4. Start Camino and visit the URL again.

Expected result:
page should look as in step 1.

Actual result:
page looks as in step 2.

Possible fixes:

Look for a usermade ad_blocking.css and, if found, use this instead of Camino's
built in (easy fix, but really not better tha turning of adblocking and using
userContent.css).

Make userContent.css load after the ad_blocking.css (no idea how hard this will be).

Allow the user to create an exception/extension-list that will be loaded
together with the built-in list (no idea if this is doable)./rehtegot lliw taht
tsil-

Comment 1

[Torben]

> /rehtegot lliw taht tsil-
I have no idea where this come from, I didn't put that in (but it is random
words from my comment backwards).

Comment 2

[Torben]

> Allow the user to create an exception/extension-list that will be loaded
> together with the built-in list (no idea if this is doable).

I got this working with some @import-magic

1. Rename ad_blocking.css within the program-bundle to ad_blocking2.css
2. Create a new ad_blocking.css containing only the following

  @import url("ad_blocking2.css");
  @import url("<path to profile folder>/chrome/ad_blocking.css");

3. (optional) Create ad_blocking.css in your profile/chrome/ containg your
   exeptions. Camino works fine without this file.

<path to profile folder> must of course be replaced with your own (full) path, I
don't know how we can get this automagically.

(BTW, the strange text in comment 0 is because of bug 305183.)

Comment 3

[Simon Fraser [no longer active]]

Hopefully being able to override ad-blocking rules in userContent.css will be
fixed via bug 305026.

I'm going to cleans the ad-blocking.css rules to avoid too many false positives
via bug 296783.

Comment 4

[Torben]

(In reply to comment #3)
> Hopefully being able to override ad-blocking rules in userContent.css will be
> fixed via bug 305026.

Yes, I can now succesfully override the adblocking through userContent.css.

(There is one small nit, when you disable adblocking through the preference
rules in userContent.css is not disabled. The procedure in comment 2 does this,
but I don't think the added complexity (for the user) makes it worthwhile.) 

Comment 5

[Simon Fraser [no longer active]]

(In reply to comment #4)
> (There is one small nit, when you disable adblocking through the preference
> rules in userContent.css is not disabled.

I don't think it should be. userContent.css is now entirely under user control,
and is not affected by prefs. I think this is correct behavior.