Closed Bug 305271 Opened 19 years ago Closed 19 years ago

[FIX] Bogus assert in nsFrameManager::GenerateStateKey

Categories

(Core :: DOM: Core & HTML, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta4

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

()

Details

(Keywords: fixed1.8)

Attachments

(1 file)

Bob ran into this:

ASSERTION: nsFrameManager::GenerateStateKey didn't find form control index!:
'index > -1', file nsContentUtils.cpp, line 1487

at http://developer.ebay.com/DevProgram/?ssPageName=home:f:f:US

The problem is that this will file any time we're restoring state for an
nsIFormControl which is not in form.elements.  Minimal testcase is in the URL field.

Given that this is a perfectly normal situation, I think we should just remove
this assert.
Priority: -- → P2
Target Milestone: --- → mozilla1.8beta4
Attached patch Proposed patchSplinter Review
Attachment #193229 - Flags: superreview?(peterv)
Attachment #193229 - Flags: review?(peterv)
Comment on attachment 193229 [details] [diff] [review]
Proposed patch

So should we be using the index of the control in the document in that case?
(cf
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsContentUtils.cpp#151
8)
Attachment #193229 - Flags: superreview?(peterv)
Attachment #193229 - Flags: superreview+
Attachment #193229 - Flags: review?(peterv)
Attachment #193229 - Flags: review+
This is a pretty rare case, so I think it's OK to fall back on the content ID here.
Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 193229 [details] [diff] [review]
Proposed patch

Requesting 1.8b4 approval -- very safe patch that removes a bogus assertion.
Attachment #193229 - Flags: approval1.8b4?
Flags: blocking1.8b4+
Attachment #193229 - Flags: approval1.8b4? → approval1.8b4+
Fixed on branch.
Keywords: fixed1.8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: