Closed Bug 305281 Opened 19 years ago Closed 19 years ago

OS/2: Firefox fails to start

Categories

(Core :: XPCOM, defect)

x86
OS/2
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: dragtext, Assigned: dougt)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

On OS/2, Firefox terminates because profiles.ini is being handled as text rather
than binary.  When read, the number of bytes returned doesn't equal the file's
size because the line terminators have been changed.

xpcom/glue/nsINIParser.cpp contains a #define for XP_WIN to deal with this.  The
attached patch extends the #define to include XP_OS2 as well.
a setanimret xoferiF
FL ot FLRC morf degnahc gnidaer si
Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

looks good.  if it works, lets get it into the trunk asap!
Attachment #193239 - Flags: review+
Fix checked in.
57 seconds to get a patch reviewed & another 9 minutes, 9 seconds to get it
checked in - that's pretty good :-)

> a setanimret xoferiF
> FL ot FLRC morf degnahc gnidaer si

Now, if only we knew what's wrong with html text areas in today's build...
i was wondering if you were banging your head on the keyboard.. :-)
> a setanimret xoferiF
> FL ot FLRC morf degnahc gnidaer si

These are actually snippets of stuff I edited out - but in reverse!  It reads
"Firefox terminates a"
"is reading changed from CRLF to LF"
"a setanimret xoferiF" looks like bug 305239
Can this bug now be RESOLVED FIXED?
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

This is needed on the 1.8 branch as well, a Firefox without it has the same
problems as on trunk.
Attachment #193239 - Flags: approval1.8b5?
Comment on attachment 193239 [details] [diff] [review]
patch to nsINIParser.cpp

a=mkaply
Attachment #193239 - Flags: approval1.8b5? → approval1.8b5+
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: