Closed
Bug 305291
Opened 19 years ago
Closed 19 years ago
move native theme code from gfx to widget
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
References
Details
Attachments
(1 file, 1 obsolete file)
|
41.96 KB,
patch
|
pavlov
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
In preparation for gfx going away, native theme code should be moved into
widget. The attached patch does this; there are some small changes to the
native theme code as well to fix quirks, which will be a separate patch once we
can get that diff up.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Comment 2•19 years ago
|
||
complete patch including the small changes the various native theme code
Attachment #193253 -
Attachment is obsolete: true
|
||
Updated•19 years ago
|
Attachment #193261 -
Flags: superreview?(roc)
Attachment #193261 -
Flags: review+
Comment on attachment 193261 [details] [diff] [review]
complete patch
looks good.
Attachment #193261 -
Flags: superreview?(roc) → superreview+
|
|
||
Comment 4•19 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 5•19 years ago
|
||
Could this have caused bug 305612 and/or bug 305632?
|
||
Comment 6•19 years ago
|
||
This may also have casued bug 305651.
|
||
Comment 7•19 years ago
|
||
Why is there nsNativeThemeQt.cpp/h in widget/src/mac now?
See also bug 305662, which this caused.
|
||
Comment 8•19 years ago
|
||
So, why did you guys fork nsNativeThemeGTK.cpp? Why not put one copy in a
shared directory, or make one reach into the other directory? Forking code is
bad =)
|
|
||
Comment 9•19 years ago
|
||
I filed bug 308387 on unforking nsNativeThemeGTK.cpp
|
||
Comment 10•19 years ago
|
||
*** Bug 275365 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•