305291 - move native theme code from gfx to widget

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

In preparation for gfx going away, native theme code should be moved into
widget.  The attached patch does this; there are some small changes to the
native theme code as well to fix quirks, which will be a separate patch once we
can get that diff up.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: native-theme-move.patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: complete patch

complete patch including the small changes the various native theme code

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 193261 [details] [diff] [review]
complete patch

looks good.

Comment 4

[Stuart Parmenter]

checked in

Comment 5

[Steve England [:stevee]]

Could this have caused bug 305612 and/or bug 305632?

Comment 6

[Bill Gianopoulos [:WG9s]]

This may also have casued bug 305651.

Comment 7

[Simon Fraser [no longer active]]

Why is there nsNativeThemeQt.cpp/h in widget/src/mac now?

See also bug 305662, which this caused.

Comment 8

[Darin Fisher]

So, why did you guys fork nsNativeThemeGTK.cpp?  Why not put one copy in a
shared directory, or make one reach into the other directory?  Forking code is
bad =)

Comment 9

[Darin Fisher]

I filed bug 308387 on unforking nsNativeThemeGTK.cpp

Comment 10

[Makoto Kato [:m_kato]]

*** Bug 275365 has been marked as a duplicate of this bug. ***