305345 - If find toolbar is already opened, if you press "'" or "/" key on browser, the character should not be set to find toolbar

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If find toolbar is already opened and you press "'" or "/" key on browser, the
character should not be set to find toolbar.(It should set focus to find toolbar
and should change find mode only.)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I assume you mean "if the find toolbar is open and does not have focus"?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yes, that's right.

Comment 3

[Asaf Romano (gone)]

hrm, won't this break finding anything with "/" using FAYT only?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that in many case, the input is not wanted. These keys are shortcut for
FAYT(See seamonkey's Edit menu). It is not inputed the character for find.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> It is not inputed the character for find.

It is not for inputting the character for find.

Comment 6

[Mats Palmgren (inactive)]

(In reply to comment #4)
> I think that in many case, the input is not wanted. These keys are shortcut for
> FAYT(See seamonkey's Edit menu). It is not inputed the character for find.

I want to be able to search for "it's" by typing /it's
Please don't break this.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #6)
> I want to be able to search for "it's" by typing /it's
> Please don't break this.
Of course.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The risk is very low.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to branch.