305357 - bump SeaMonkey version for trunk to post-1.0

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Robert Kaiser]

Currently, both 1.8 branch and trunk version of SeaMonkey report "1.0a" as the
version number, but that's only correct for branch, trunk is headed to some
post-1.0 stage already...
To avoid confusion, we should bump the version on trunk to something more
fitting. As we haven't decided yet what our 1.9-based version will be called, we
should probably be conservative and go for the lowest possible post-1.0 version
number, being 1.1a (we can always bump up again later, correcting to a lower
version later might be worse, up is no real problem).

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch

Comment 2

[Robert Kaiser]

Stephend, sorry to say that, but the patch you attached is the likely most
insignificant place where we need to change it ;-)

Anyways, doing the patch is the easy part here, the hard part is to get all of
the SeaMonkey Council to agree to one number to change it to ;-)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, can't that file use some automated way to get the version?

(I'd also pick 1.1a)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Heh, I figured it was too simple to be true ;-)  Anyway, I shouldn't be stealing
your thunder, as you assigned this bug to yourself ;-(.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Anyways, doing the patch is the easy part here, the hard part is to get all of
> the SeaMonkey Council to agree to one number to change it to ;-)

v1.0+ could be possible too, but v1.1a seems just fine (to avoid confusion).

As a reminder, getting a Target Milestone in BugZilla would be good then.

Comment 6

[Robert Kaiser]

(In reply to comment #3)
> hmm, can't that file use some automated way to get the version?

It can, but it needs a patvh nearly as big as the one I did for enabling
@MOZ_APP_DISPLAYNAME@ in there... the other (non-string) version number can't be
automated that easily though, unfortunately (at least from what I know)...

(In reply to comment #5)
> v1.0+ could be possible too, but v1.1a seems just fine (to avoid confusion).

Nah, we want to avoid those '+' versions if possible in any way.

> As a reminder, getting a Target Milestone in BugZilla would be good then.

Target Milestone entry will only be necessary as soon as we have decided on how
our post-1.0 milestones will be called. Thanks for reminding, but it doesn't
really make sense yet...

Comment 7

[Robert Kaiser]

Attachment: bump to 1.1a

OK, here's a patch that bumps us to 1.1a on trunk.

Comment 8

[[e-mail]]

Comment on attachment 193811 [details] [diff] [review]
bump to 1.1a

>Index: mozilla/xpfe/bootstrap/module.ver
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/bootstrap/module.ver,v
>retrieving revision 1.4
>diff -u -7 -p -r1.4 module.ver
>--- mozilla/xpfe/bootstrap/module.ver	27 Jul 2005 23:27:56 -0000	1.4
>+++ mozilla/xpfe/bootstrap/module.ver	25 Aug 2005 14:26:38 -0000
>@@ -1,8 +1,8 @@
> WIN32_MODULE_COMPANYNAME=mozilla.org
> WIN32_MODULE_COPYRIGHT=©Mozilla Developers, according to the MPL 1.1/GPL 2.0/LGPL 2.1 licenses, as applicable.
>-WIN32_MODULE_PRODUCTVERSION=1,0,0,0
>-WIN32_MODULE_PRODUCTVERSION_STRING=1.0a
>+WIN32_MODULE_PRODUCTVERSION=1,1,0,0
>+WIN32_MODULE_PRODUCTVERSION_STRING=1.1a
> WIN32_MODULE_TRADEMARKS=SeaMonkey and Mozilla are trademarks of The Mozilla Foundation.
> WIN32_MODULE_DESCRIPTION=@MOZ_APP_DISPLAYNAME@
> WIN32_MODULE_PRODUCTNAME=@MOZ_APP_DISPLAYNAME@
> WIN32_MODULE_NAME=@MOZ_APP_DISPLAYNAME@
>Index: mozilla/xpfe/bootstrap/version.txt
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/bootstrap/version.txt,v
>retrieving revision 1.1
>diff -u -7 -p -r1.1 version.txt
>--- mozilla/xpfe/bootstrap/version.txt	2 Jul 2005 20:35:11 -0000	1.1
>+++ mozilla/xpfe/bootstrap/version.txt	25 Aug 2005 14:26:38 -0000
>@@ -1 +1 @@
>-1.0a
>\ No newline at end of file
>+1.1a
>\ No newline at end of file

Comment 9

[Robert Kaiser]

Checked in.

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050826 SeaMonkey/1.1a]
(nightly) (W98SE)

V.Fixed