305360 - Add ability to change default quit message on ChatZilla

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[David Eccles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

I have noticed that there does not appear to be any functionality for changing
the default reason for quitting ChatZilla. I didn't notice any obvious
preferences in the program for this functionality, so had a quick browse through
the source code  (chatzilla-0.9.68.5) to confirm this. I noticed that the
cmdQuit(e) function in content\chatzilla\commands.js appears to only spit out
the userAgent string if a reason is not given (found around line 1417 of
command.js). It would be nice if this quit message could be customised by a user
preference, so that people can change their message to say something other than,
 "I decided to quit because I used 'Chatzilla 0.9.68a [Firefox 1.0.6/20050716]'.

Reproducible: Always

Steps to Reproduce:
1. type "/quit" [with no reason] from within ChatZilla

Actual Results:  
Displays a quit message, with the client.userAgent as a reason for quitting.

Expected Results:  
Display a custom quit message (most likely defaulting to the userAgent string)
when no reason is given.

I'm not familiar at all with the preference collections etc., so I'm putting
this in as a suggestion rather than a patch.

Current code from chatzilla-0.9.68.5 (content\chatzilla\commands.js:1417):
function cmdQuit(e)
{
    if (!e.reason)
        e.reason = client.userAgent;
    client.quit(e.reason);
    window.close();
}

Proposed new code:
function cmdQuit(e)
{
    if (!e.reason)
    {
        if (!client.prefs["quitMessage"])
             e.reason = client.userAgent;
        else
             e.reason = client.prefs["quitMessage"];
    }
    client.quit(e.reason);
    window.close();
}

Comment 1

[James Ross]

I've got this ready in 0.9.68.6 already. :)

Comment 2

[James Ross]

Attachment: [checked-in] Add default quit msg preference

Comment 3

[Samuel Sieb]

Comment on attachment 193377 [details] [diff] [review]
[checked-in] Add default quit msg preference

Might be nice to be able to specify it per network though.

Comment 4

[James Ross]

Comment on attachment 193377 [details] [diff] [review]
[checked-in] Add default quit msg preference

Checked in. Leaving bug open for per-network update.

Comment 5

[:Gijs (he/him)]

Attachment: Patch for a network-specific message

I've moved the client quit message as well, to keep them in the same place (as there's no Global tab for networks).

So, this modifies client.quit and the disconnecting commands to use the network pref. As this defers to the client pref, everything works as expected (as far as I can tell).

Comment 6

[James Ross]

Checked in --> FIXED.