305390 - show user Firefox will startup after installation is complete

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050821
Firefox/1.0+ ID:2005082100

When the "Firefox is installing your updates" progresbar is at 100% it should
show a message FF is being restarted.
Especially on older systems the startup may take 10-15 secs and the user may
wonder if he manually needs to start FF or if it's done automatically

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Comment 2

[u88484]

would be great because this just happend to me a minute before i read this bug.
I was sitting here wondering if the browser was actually starting or not on my
amd k6.

Comment 3

[Shayne Jewers]

Attachment: Change updater text

adds 'and will restart after update completes' to updater window

Comment 4

[Shayne Jewers]

Comment on attachment 193513 [details] [diff] [review]
Change updater text

ok, that makes 'completes' go on another line, causing it to get cut off, will
make another patch with shorter text

Comment 5

[Shayne Jewers]

Attachment: Change the text on Software Update window (shorter text than above patch)

this should work

Comment 6

[Peter van der Woude [:Peter6]]

(In reply to comment #5)
> Created an attachment (id=193518) [edit]
> shorter text
> 
> this should work

-Info=Firefox is installing updates, and will restart after completing...
+Info=Firefox is installing the update and will restart after completion...

The auto restart only happens after an app update (singular) after that the
sentence sounded soso , so I changed the latter part aswell.

I'm not sure if app update allows multiple patches though.
Like updating from 1.5.0 to 1.5.3 in 1 go.

Comment 7

[Shayne Jewers]

couldn't this impact l10n?

Comment 8

[Benjamin Smedberg]

This is the kind of string change that doesn't really affect l10n all that much,
and can be made after string freeze if necessary.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Small nit: the user interaction sequence is like this ...
  1. software Update notifies user that an update as been found
  2. user downloads & installs
  3. software Update says "time to install, now or later?"
  4. user says now (or later)
  5. firefox closes (or user closes it later)
  6. firefox restarts (or user opens it later)
  7. this dialog pops up
  8. firefox starts

The dialog in step 4 (iirc) clearly indicates that Firefox will restart, so I
don't think we need any more indication there. And really, it's not *re*starting
between steps 7 and 8, but rather just applying the updates and starting.

So how about:

"Firefox is installing your updates and will start in a few moments ..."

 - or -

"Please wait as Firefox installs your updates before opening ..."

Comment 10

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> So how about:
> 
> "Firefox is installing your updates and will start in a few moments ..."
> 
>  - or -
> 
> "Please wait as Firefox installs your updates before opening ..."

my vote for the first 1

Comment 11

[Shayne Jewers]

Attachment: change updater text to option 1 on comment 9 per comment 10

i dunno who should review this/superreview, so someone else set the review
flags :<

Comment 12

[Peter van der Woude [:Peter6]]

Mike, if you could be so kind to r/sr the patch

Comment 13

[Aaron Slunt]

Comment on attachment 193621 [details] [diff] [review]
change updater text to option 1 on comment 9 per comment 10

Requesting review for shaynejewers per comment 11.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 193621 [details] [diff] [review]
change updater text to option 1 on comment 9 per comment 10

Could you also patch mozilla/mail/locales/en-US/updater/updater.ini to match
the behaviour in Thunderbird? Then I'll happily r+ :)

Comment 15

[Shayne Jewers]

Attachment: Changes updater text on TB also

this changes the updater,ini on TB too

Comment 16

[Asa Dotzler [:asa]]

this impacts l10n so I'm adding the keyword for a heads up.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/browser/locales/en-US/updater/updater.ini; new revision: 1.4;
mozilla/mail/locales/en-US/updater/updater.ini; new revision: 1.3;

1.8 Branch:
mozilla/browser/locales/en-US/updater/updater.ini; new revision: 1.3.2.1;
mozilla/mail/locales/en-US/updater/updater.ini; new revision: 1.2.2.1;

FIXED.