305435 - Remove MNG image support listitem from pref window.

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: 2005-08-21-05, Windows XP SeaMonkey trunk.

Summary: Remove MNG image support listitem from pref window.

So, we have bug 18574, which is to 'restore MNG support', but since we don't
have support, it makes no sense to have 'support' (in the form of a checkbox)
for it in our preferences.

See http://www.libmng.com/MNGsuite/past_embed.html for proof that we don't
support MNG.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch

Comment 2

[Hermann Schwab]

Maybe it the checkbox is still usable?
http://extensionroom.mozdev.org/more-info/mngsupport

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

extensions should come with their own prefs... providing pref UI that is _only_
usable with an extension does not seem like a good idea to me.

Comment 4

[[e-mail]]

Comment on attachment 193381 [details] [diff] [review]
Patch

Could we leave the string in too to make it easier for the MNG extension author
;-)

Comment 5

[[e-mail]]

Comment on attachment 193381 [details] [diff] [review]
Patch

Could we leave the string in too to make it easier for the MNG extension author
;-)

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 193381 [details] [diff] [review]
Patch

Trivial, no-risk SeaMonkey only patch.

Comment 7

[OstGote!]

So I guess Bug 210934 could be duped against this one?

Comment 8

[Aaron Kaluszka]

This patch didn't remove the references in nsWindowsHooks.cpp, however, those
references would be required should a MNG extension want to add the lines back
that this patch removed.  (Ideally we need a fix for bug 160896).  So whether
bug 210934 is truly fixed is up to the module owner.

Comment 9

[Alexander Opitz]

If this is an SeaMonkey only bug why we remove this if we plan to readd MNG to
SeaMonkey?
Do we want it in SM1.0 or not? Would be nice to know I don't want spent time for
something that won't happen.

Comment 10

[Robert Kaiser]

(In reply to comment #9)
> If this is an SeaMonkey only bug why we remove this if we plan to readd MNG to
> SeaMonkey?

Who said we plan it? We can't plan to include something that's not in CVS yet.
Don't mistake me, I'd be the first to vote for an inclusion, but before I'd even
discuss it, I want to see some form of supporting it in mozilla.org CVS.

Comment 11

[Alexander Opitz]

But we both know that MNG will rejected by pavlov cause he mean nobody needs
that (instead of his aPNG *uh*) so we run into the chicken and egg problem.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:
Checking in xpfe/components/prefwindow/resources/content/pref-winhooks.xul;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-winhooks.xul,v
 <--  pref-winhooks.xul
new revision: 1.34.6.1; previous revision: 1.34
done
Checking in
xpfe/components/prefwindow/resources/locale/en-US/pref-winhooks.dtd;/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-winhooks.dtd,v
 <--  pref-winhooks.dtd
new revision: 1.15.6.1; previous revision: 1.15
done