305436 - Consider whether we really need to try and migrate ldap prefs in various locations.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

This bug originates from investigations during bug 58696 (see
https://bugzilla.mozilla.org/show_bug.cgi?id=58696#c34).

Currently nsILDAPPrefsService is obtained in 4 different places (throughout the
seamonkey code - thunderbird is the same just in branched code). The places are:
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/addressbook.js#185
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/prefs/resources/content/pref-directory.js#20
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/MsgComposeCommands.js#137
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMessengerMigrator.cpp#736

addressbook.js and MsgComposeCommands.js only do a call to get the ldap prefs
service. MsgComposeCommands.js takes a copy of it but then doesn't actually use
it (and also the seamonkey version gets it wrong at the moment).

Having found that out, I then investigated what happens when we migrate
preferences from netscape 4.x. In most situations, the nsMessengerMigrator did
the migration before addressbook.js or MsgComposeCommands.js got to it. The only
case where this didn't occur was with preferences. Start up seamonkey with the
browser (and migrating 4.x), then go into prefs - the ldap prefs need to be
migrated there.

So this bug is really to examine whether or not we need to do a call to migrate
prefs in addressbook.js and/or MsgComposeCommands.js. We need to look at all the
possible combinations and come up with an agreed solution.

Comment 1

[Mark Banner (:standard8)]

Note to self see also Bug 94641

Comment 2

[Mark Banner (:standard8)]

I don't think I'm going to get around to this any time soon, but it'd still be interesting to check up on.

Comment 3

[Mark Banner (:standard8)]

This bug doesn't apply any more - the patch on bug 379647 has resolved this.