305447 - packager.mk doesn't leave safe symbolic links alone

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

packager.mk shouldn't interfere with safe symbolic links.  A safe symlink is
relative and points within the tree.  Such links should be preserved in the
packaged dmg rather than copying the link's referent.

rsync has an option, --copy-unsafe-links, which produces the desired behavior. 
It should replace -L (--copy-links) when rsync is used in packager.mk. 
--copy-unsafe-links is used elsewhere in the build (although nowhere that it
would currently make a difference) and is supported in the rsync versions
present on all supported Mac build platforms.

This is causing slight bloat in Camino now that it's moved to the mainstream
packager, because Camino bundles a framework and frameworks are notoriously
populated with all sorts of symlinks pointing within themselves.  This change
will not interfere with other packaged applications, which don't currently
include any safe symlinks.

Comment 1

[Mark Mentovai]

Attachment: Patch

If it's all the same to everyone else, I'd like this for 1.8b4.  It's a size
regression for Camino, and the patch is safe.

Comment 2

[Mark Mentovai]

Fixed on trunk.

Comment 3

[Josh Aas]

getting this fix on the radar by requesting 1.8b4