packager.mk shouldn't interfere with safe symbolic links. A safe symlink is relative and points within the tree. Such links should be preserved in the packaged dmg rather than copying the link's referent. rsync has an option, --copy-unsafe-links, which produces the desired behavior. It should replace -L (--copy-links) when rsync is used in packager.mk. --copy-unsafe-links is used elsewhere in the build (although nowhere that it would currently make a difference) and is supported in the rsync versions present on all supported Mac build platforms. This is causing slight bloat in Camino now that it's moved to the mainstream packager, because Camino bundles a framework and frameworks are notoriously populated with all sorts of symlinks pointing within themselves. This change will not interfere with other packaged applications, which don't currently include any safe symlinks.
Created attachment 193388 [details] [diff] [review] Patch If it's all the same to everyone else, I'd like this for 1.8b4. It's a size regression for Camino, and the patch is safe.
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
getting this fix on the radar by requesting 1.8b4
Attachment #193388 - Flags: approval1.8b4? → approval1.8b4+
You need to log in before you can comment on or make changes to this bug.