305464 - Corrupt Firefox installer shows only '7-zip Unspecified error'

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050819 Firefox/1.0+

Running a corrupt Firefox installer, pops up an unclear error alert.

Reproducible: Always

Steps to Reproduce:
1. Start downloading the latest Fx nightly.
2. Pause the download after a few hundred kB have been downloaded.
3. Copy the file 'firefox-1.0+.en-US.win32.installer.exe.part' somewhere on your
disk, and delete the '.part' suffix of the filename.
4. Try to run the file.
5. The error alert '7-zip Unspecified Error' appears.
Actual Results:  
Error alert window with the text "7-zip Unspecified Error" appears.

Expected Results:  
Error alert window with the text "7-zip This file is corrupt. Clear your cache,
delete this file, and download it again" should appear.

Slightly off topic. While searching for duplicates, I found these bugs:
Bug 268338 should be marked Invalid.
Bug 246765 will be fixed after mine is fixed.

This is the part of Firefox code that needs to be changed:
http://lxr.mozilla.org/aviary101branch/source/security/nss/cmd/modutil/install.c#111

This is my first bug. Sorry in advance for any mistakes. Please be gentle :)

Comment 1

[Frank Wein [:mcsmurf]]

confirming.

Comment 2

[Edward Z. Yang]

Hmm... I'd say at worst resolution should be WONTFIX or change status to
ENHANCEMENT/MINOR. A major bug = major loss of function, but that goes without
saying if you don't have a complete installer...

You're suggesting that the error message should be a bit gentler. I'd go with MINOR.

I also suspect that making the fix in Firefox code wouldn't be possible, because
it seems like the error is originating from 7-Zip (7-Zip?!?! I didn't know they
used 7-Zip!)

Comment 3

[Frank Wein [:mcsmurf]]

I was told that code lives under
http://lxr.mozilla.org/mozilla/source/other-licenses/7zstub/, also i'm not sure
(since there is only one file).

Comment 4

[bugzilla]

(In reply to comment #2)

It is a very, very common question (top 3) in the mozillazine forums, after
every new release. It should be fixed ASAP because it has l10n impact. It's a
simple fix.

Comment 5

[donnie_durton]

tried everything, tried many different downloads, still says "7-zip" and "unspecified error"

Comment 6

[Kathy S.]

Attachment: Mistake - please ignore

Comment 7

[Kathy S.]

Comment on attachment 215406 [details]
Mistake - please ignore

I'm very sorry. I didn't understand how this works and I thought I was going to get a patch, not "create one". Sorry for the misunderstanding and any inconvenience this may have caused anyone.
><>Kathy<><

Comment 8

[Kathy S.]

Comment on attachment 215406 [details]
Mistake - please ignore

I'm very sorry. I didn't understand how this works and I thought I was going to get a patch, not "create one". Sorry for the misunderstanding and any inconvenience this may have caused anyone.
><>Kathy<><

Comment 9

[Hermann Schwab]

Comment on attachment 215406 [details]
Mistake - please ignore

Comment 10

[Robert Strong (they/them - no direct email)]

One could say the same thing about any partially completed download where the .part is removed and this isn't something we are going to modify 7-Zip for which we use unmodified. If 7-Zip changes this we'll go along for the ride.