305466 - register-global doesn't work correctly

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: XULRunner, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

I have upgraded to a newer snapshot of xulrunner and got the following behaviour
while trying to register the GRE:

Hygiea:~ # xulrunner --register-global
Warning: Configuration file '/etc/gre.d/1.8b4_2005073100.conf' already exists.
No action was performed.
Hygiea:~ # xulrunner --unregister-global
Hygiea:~ # ll /etc/gre.d
insgesamt 11
drwxr-xr-x   2 root root   88 2005-08-20 21:21 .
drwxr-xr-x  89 root root 7448 2005-08-19 09:56 ..
-rw-r--r--   1 root root  113 2005-08-01 11:53 1.8b4_2005073100.conf
Hygiea:~ # xulrunner --register-global
Hygiea:~ # ll /etc/gre.d
insgesamt 15
drwxr-xr-x   2 root root  128 2005-08-22 06:47 .
drwxr-xr-x  89 root root 7448 2005-08-19 09:56 ..
-rw-r--r--   1 root root  113 2005-08-01 11:53 1.8b4_2005073100.conf
-rw-r--r--   1 root root  113 2005-08-22 06:47 1.9a1_2005081900.conf

The first try was unsuccessful while the second after calling unregister-global
was called was successful. This is strange because nothing changed in /etc/gre.d/

Comment 1

[Benjamin Smedberg]

When you call -register-global we store a file in the xulrunner directory called
"global.reginfo", which tells us what .conf file we wrote out. It sounds like
you did --register-global <upgrade> --register-global, and the install found the
existing global.reginfo file, and refused to register again.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

what I do (within the RPM) for the upgrade case is:

1. call xulrunner --unregister-global from old xulrunner
2. install new xulrunner
3. call xulrunner --register-global

That fails. And after your explanation I know why:
global.reginfo is still there in the path (if it's the same path which is the
case for updating snapshots).
I can workaround this in the RPM scripts but I'm not sure if this is the correct
approach. As xulrunner knows its own version why does it need to read from
global.reginfo for this?

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

... or delete global.reginfo on unregistering (which isn't done as it seems)

Comment 4

[Benjamin Smedberg]

We definitely should be deleting global.reginfo when we --unregister-global...
that's the bug.

Comment 5

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/xulrunner/app/nsRegisterGREUnix.cpp#278

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

yes, it seems it gets deleted. I have to dig deeper into what happens during the
RPM update phase.

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

sorry for the spam. --unregister-global wasn't called correctly.