305467 - Failure to mark headers as downloaded on cancel/stop results in duplicates.

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I looked briefly for a DUP, but wanted to get this filed just in case it's not
already known.

Build ID: version 1.6a1 (20050821) Windows XP.

Summary: Failure to mark headers as downloaded on cancel/stop results in duplicates.

Steps to Reproduce:

1. Enter a not-yet-subscribed newsgroup (my example was alt.tv.lost)
2. Choose "Download all headers"

Here, you can do a couple of things to reproduce the bug:

A) Click "Stop", followed by "Get Mail"
B) You can go to any folder, and then come back to your newsgroup

The results are the same: the download headers dialog will always tell you the
max # of headers are available for download.

3. Repeating either (A) or (B) will result in an identical header, which will be
threaded off the original.

[00:07] <bienvenu> basically, we're not updating our variables that say what
headers we've downloaded
[00:07] <bienvenu> when you press cancel
[00:07] <bienvenu> definitely a bug

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[David :Bienvenu]

Attachment: proposed fix

FinishXOVERLine gets called even when download is cancelled - parsing headers
keeps track of the last header parsed, so it should be up to date.

Comment 3

[Scott MacGregor]

Comment on attachment 193622 [details] [diff] [review]
proposed fix

this looks pretty low risk and is already a 1.8b4+ blocker bug.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry David, I left out a crucial part of step B, which leads to the original
problem I described (though you did indeed fix both A and B as I originally stated):

Since it's my fault, let me know if you want a new bug for this.

Anyways, here are the steps:

1. Subscribe to alt.tv.alias (~4439 articles)
2. Choose "Download all headers", click Download
3. Let it start downloading
4. Go to your Inbox
5. Come back to alt.tv.alias

Now, this is the *extra* step I left out of part (B):

6. Click the Get Mail button.

Now you'll have an extra copy of each header.

Comment 5

[David :Bienvenu]

yes, a new bug would be good - in the second case, we're probably just getting
new headers with a second connection, even though we have a connection getting
headers for that newsgroup already, which is a different problem.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Okay, back to Verified FIXED (trunk) for the specific cases I already tested;
the other issue I've filed bug 305918 for.  Sorry for the mishap.