305472 - RSS icon shown for feeds in (third-party) frames

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load data:text/html,<iframe src="http://www.mozilla.org/">

Result: Feed icon in the URL bar.

Expected: No feed icon.

Comment 1

[Phil Ringnalda (:philor)]

See also bug 274915, which asked for them to be shown, back when they weren't.

Comment 2

[Peter van der Woude [:Peter6]]

Just as simple as adding a <link rel="alternate" type="application/rss+xml" ...>
from another site on your page.

Comment 3

[Daniel Veditz [:dveditz]]

Why wouldn't you want to show feeds from a frame? If you have multiple feeds it
does show where the feed itself is going to come from which would be the
important thing, I would think.

If there's only one it jumps to the "add live bookmark" dialog with no clue what
the feed actually is. *That* seems like a bad idea (but has nothing to do with
being in a frame)

Comment 4

[Jesse Ruderman]

> Why wouldn't you want to show feeds from a frame?

Because you can't tell they're coming from a frame, and showing the icon in the
address bar makes it seem like they're coming from the main page.

> If you have multiple feeds it does show where the feed itself is going to come 
> from

I don't see that using the testcase in the URL field of this bug.  All I see in
the menu is the feed's name, not the URL or the fact that the feed is coming
from a frame.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050916
Firefox/1.6a1

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #3)
> If you have multiple feeds it
> does show where the feed itself is going to come from which would be the
> important thing, I would think.

data:text/html,<iframe width=0 height=0 
src="http://www.mozilla.org/"></iframe><iframe width=0 height=0 
src="http://www.extensionsmirror.nl/peter6/rss_link.html"></iframe>

give no clue where they originate from, you can only get that info when you ask
properties once you've created the live bookmark

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050916
Firefox/1.4 ID:2005091614

Comment 6

[Phil Ringnalda (:philor)]

Hover the menu options, you should get the feed URL in a tooltip (at least, on
Win you do).

My use case for showing them is the thousands of weblogs (sadly, I mean that
number literally) I've seen run on cheap/free domain hosting that just frames
the content elsewhere. Got a good real-world counter-example, where you wouldn't
want it to come through? The only place I see third-party frames these days is
about.com, where I kill them right away - do webmail hosts still frame the
content of links that are sent to you?

The one place I maybe would buy shutting off showing them would be for 1.5 if we
can't manage to fix the bug that I hope is filed on the way we don't remove
feeds from frames on subframe navigation, so if you start from that framed m.o,
follow the link to planet.m.o, then a link to someone's source weblog, then a
link to another weblog, you wind up with the history of everywhere you've been
in the feed menu. Even then, being stuck in a frame sucks, and that's just
another way it sucks.

Comment 7

[Phil Ringnalda (:philor)]

This is currently WFM, but I'm not closing the bug, since that was accidental, and could be accidently undone just as easily.

Comment 8

[Robert Sayre]

wfm, but we should get a test in

Comment 9

[Elmar Stellnberger]

 Sites that use URL-Framing depend on rss-links to be discovered in sub-frames. RSS-discovery in sub-frames should be supported in any case. Nonetheless it is a question whether to show the sub-frame where an rss is coming from in a popup-menu before directly adding it to the reader.