305476 - Group membership inheritance broken in editusers.cgi

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P2)

Description

[Marc Schumann [:Wurblzap]]

This is a regression of bug 304583.

1. Log in as a member of the admin group
2. Create a new group (automatically getting admin inheritance) with no regexp
3. Using editusers.cgi, show all members of the new group
4. Wonder why there are no users shown, particularly not your own user

The reason is that selection by group relies on user_group_map entries for
derived group membership, which don't exist any more.

Continued:
5. Show your user in editusers.cgi
6. Wonder why there is no mark-up for inherited membership to the new group

The reason is that userDataToVars doesn't retrieve "derivedmember" information
any more.

Comment 1

[Joel Peshkin]

I'll investigate this today.

Comment 2

[Joel Peshkin]

Attachment: Fixed in both places

I hate these queries that populate hash members based on the field names in the
SQL.

There were 2 problems here... both fixed.
1) userDataToVars() uses field names as hash member names. 
2) the selection by group id needed to flatten the desired group first.

Comment 3

[Marc Schumann [:Wurblzap]]

Comment on attachment 193440 [details] [diff] [review]
Fixed in both places

>@@ -656,7 +655,8 @@
>         qq{SELECT id,
>                   COUNT(directmember.group_id) AS directmember,
>                   COUNT(regexpmember.group_id) AS regexpmember,
>-                  CASE WHEN groups.id IN ($grouplist) THEN 1 ELSE 0 END,
>+                  (CASE WHEN groups.id IN ($grouplist) THEN 1 ELSE 0 END) 
>+                      AS derivedmember,
>                   COUNT(directbless.group_id) AS directbless
>            FROM groups
>            LEFT JOIN user_group_map AS directmember

This returns "1" too often; the derivedmember column should be 1 if membership
is because of inheritance only, and this returns "1" for every group the user
account is a member of, directly or indirectly.
This could be solved at template level if it's not feasible to do it here.

Comment 4

[Joel Peshkin]

Attachment: v2 - exclude non-dreived groups

Comment 5

[Frédéric Buclin]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.99; previous revision: 1.98
done