305501 - tabs preferences uses wrong accesskey entity for loading tabs in background

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Ronny Perinke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050819 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050819 Firefox/1.0+

tabs.xul uses the wrong accesskey entity for the 'loadInBackground' option.
It should be 'loadInBackground.accesskey' instead of
'loadBookmarksInBackground.accesskey' because 'loadBookmarksInBackground' is not
used in tabs.xul.

What makes me wondering is, that loadBookmarksInBackground is used a pref which
can not be set within the tabs prefs, but the l10n entities are available.
http://lxr.mozilla.org/mozilla1.8/search?string=loadBookmarksInBackground
I think it should be in the tabs prefs otherwise it should be removed from l10n.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ronny Perinke]

Attachment: fixes the wrong entity

Comment 2

[Dave Townsend [:mossop]]

Confirming. Requesting blocking since this has l10n implications.

Ronny, you need to request review from a particular person on your patch.

Comment 3

[Ronny Perinke]

(In reply to comment #2)
> Ronny, you need to request review from a particular person on your patch.
> 

Ok, thanks. I was a unsure, what to fill in the requestee field.

>Requesting blocking since this has l10n implications.
>

Well, I don't know if it affects l10n, because the correct locale entity is
already there. ->
http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/browser/preferences/tabs.dtd#19

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Trunk: browser/components/preferences/tabs.xul; new revision: 1.9;
1.8 Branch: browser/components/preferences/tabs.xul; new revision: 1.8.2.1;