305508 - Autofill for different pages and form elements with the same name

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect)

Description

[Achim Schilder]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.10) Gecko/20050717 Firefox/1.0.6

Different pages are called with a parameter to set the page to load:

e.g.: 
http://localhost/index.php?page=one
http://localhost/index.php?page=two

Both pages contain different forms, with an element of the same name. The
autofill function fills both elements with their value in both forms, although
the forms are completely different.

One could call it a feature, I call it a bug.



Reproducible: Always

Steps to Reproduce:
1. create two forms with an element of the same type and name
2. call the pages / forms by setting a page parameter
3. the second form contains the values of the first form (if autofill activated)

Actual Results:  
element in second form filled

Expected Results:  
should no be filled, if page called with different parameters (how to handle
sessions?)

Comment 1

[Phil Ringnalda (:philor)]

Which "autofill" do you mean? If you mean filling in username/password pairs,
that's bug 234770. If you mean autocomplete, the dropdown with possible things
to fill in when you start typing or press the down-arrow, that's a feature, and
it's not just same-filename different-query, it's every page on every site: if
you have a form with an element named q, autocomplete will offer your Google
searches, and more usefully if you have an element named email it will offer the
addresses you've used in other elements named email.

Comment 2

[Achim Schilder]

I read the description of the bug and I don't think it's the same problem, so
I'll try to explain it more exactly:

The first page is a login page with username/password. I log in and switch to an
admin page where I want to create a new user account. Among other fields like
firstname, lastname and address there are input fields for username and
password. The name of the username field differs from that on the login page,
the name of the password field is the same. When loading this page, the field
for the password is filled automatically (with my password from the login I
think). The field for the username is still blank.

The pages aren't available for public, so I cannot send you links to that problem.

Comment 3

[Achim Schilder]

A little correction: I checked it once again. The username field was filled by
the script and it has the same name as in the login form.

Comment 4

[Justin Dolske [:Dolske]]

This should work in the current satchel/pwmgr implementation. The old wallet code was broken like this, and is now deprecated.