305512 - Problems with playing alarm sounds

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

There are a couple of problems that need to be fixed for the default alarm sound
to work properly.  Robin and I discussed this a bit ago, but the necessary
changes got lost in my trees.  Robin, if you still have any of the patch(es)
related to this issue, please attach them to this bug.  I'll put them all
together in one patch for review.

Comment 1

[Robin Edrenius]

Attachment: Fix preview

This is your preview-fix patch. ruoy s

Comment 2

[Robin Edrenius]

Attachment: Show default URL and pathfix to default sound

There you go, that's what I have, I think that's everything.

Comment 3

[Joey Minta]

Attachment: composite patch

There are several problems:
-The alarm sound textbox wasn't added to the array of preference widgets
-The default path was incorrect
-The default value was never set (getCharPref actually does this, but
eventually this should be done in a separate preferences file)
-The preview option could only play 'file://' urls

All of these should be fixed in this patch.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 193460 [details] [diff] [review]
composite patch

r=mvl

Comment 5

[Joey Minta]

Patch checked in.