305517 - Packager script fails on the first time ; have to launch it twice.

Status: RESOLVED WORKSFORME

(Thunderbird :: Build Config, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050822 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050822 Firefox/1.6a1

Simple to see. After a successfull build, when I run make -C mail/installer, the
first time, it fails, saying :

Creating hybrid image...

/Users/frederic/Documents/logs/thun/mozilla/build/package/mac_osx/pkg-dmg:
exited on signal 6
/Users/frederic/Documents/logs/thun/mozilla/build/package/mac_osx/pkg-dmg:
hdiutil makehybrid failed (cleaning up)
make[1]: *** [thunderbird-1.6a1.en-US.mac.dmg] Error 1
make: *** [all] Error 2

If I run it the second time, it works flawlessly !

Reproducible: Always

Steps to Reproduce:
1.See Details.
2.
3.

Actual Results:  
Fails after saying "Creating hybrid image..."

Expected Results:  
Packaging !

It happens too for firefox. I've seen it for two days or so.

It is a very recent regression.

Comment 1

[Scott MacGregor]

looks like fall out from Bug #302080

Comment 2

[Frederic Bezies]

Maybe - in some way - a duplicate of bug 305131 ?

Comment 3

[Mark Mentovai]

Frederic, that's not enough output.  I'd like to know what pkg-dmg was trying to
do when it failed, can you give me a few more lines from above where you cut?

Comment 4

[Frederic Bezies]

I will make another build, and give you the full log following make -C mail/installer.

Just wait a little :)

Comment 5

[Frederic Bezies]

Weird !

it looks like bug only happens when I set optimization to -O2.

I tried to build with a simple --enable-optimize, and make -C mail/installer works flawlessly. Anyway the 
code I used did not include the checkin for bug 305131.

really weird.

I don't understand. I will try again tomorrow (I am living in France, so Mozilla.org time + 8 hours) and see 
if optimization is related to this really weird bug. :(

Comment 6

[Mark Mentovai]

Optimization settings have absolutely no impact on packaging.  Since this is the
only report of this I've had and you are no longer able to reproduce, I'm
marking WFM, but will continue to monitor it in case it happens to you again. 
Thanks for your report.

Comment 7

[Frederic Bezies]

I have a log you'll find more useful - and it can help you seeing the problem - of another script crash.

It is based on firefox, but as I said in comment #0, it happens in both firefox and thunderbird.

Source used was up to date at 10:00 pm, mozilla.org time.

Xcode used : 2.1 ; gcc 4.0 ; SDK 10.4 if it matters.

"[...]
Generating DSA Key Pair....done
../../dist/firefox/libsoftokn3.dylib: File not found.
Removing unpackaged files...
cd ../../dist/firefox/DeerPark.app/Contents/MacOS; rm -rf firefox-config regchrome* regxpcom* 
xpcshell* xpidl* xpt_dump* xpt_link*  core bsdecho gtscc jscpucfg nsinstall viewer TestGtkEmbed 
bloaturls.txt codesighs* elf-dynstr-gc mangle* maptsv* mfc* mkdepend* msdump* msmap* nm2tsv* 
nsinstall* rebasedlls* res/samples res/throbber shlibsign* winEmbed.exe chrome/chrome.rdf chrome/
app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat 
Compressing...
cd ../../dist; /Users/frederic/Documents/logs/fox/mozilla/build/package/mac_osx/pkg-dmg --source 
"firefox" --target "firefox-1.6a1.en-US.mac.dmg" --volname "DeerPark"  --copy "branding/
dsstore:/.DS_Store" --mkdir /.background --copy "branding/background.png:/.background" --icon 
"branding/disk.icns" --resource "branding/license.r"
mktemp -d pkg-dmg.2344.XXXXXXXX
pkg-dmg.2344.45jPRSrV
mkdir pkg-dmg.2344.45jPRSrV/stage
rsync -a --copy-unsafe-links firefox/ pkg-dmg.2344.45jPRSrV/stage
mkdir -p pkg-dmg.2344.45jPRSrV/stage/.background
rsync -a --copy-unsafe-links branding/dsstore pkg-dmg.2344.45jPRSrV/stage/.DS_Store
rsync -a --copy-unsafe-links branding/background.png pkg-dmg.2344.45jPRSrV/stage/.background
rsync -a --copy-unsafe-links branding/disk.icns pkg-dmg.2344.45jPRSrV/stage/.VolumeIcon.icns
/Developer/Tools/SetFile -a C pkg-dmg.2344.45jPRSrV/stage
chmod -R a+rX,a-st,u+w,go-w pkg-dmg.2344.45jPRSrV/stage
hdiutil makehybrid -hfs -hfs-volume-name DeerPark -hfs-openfolder pkg-dmg.2344.45jPRSrV/stage 
-ov pkg-dmg.2344.45jPRSrV/stage -o pkg-dmg.2344.45jPRSrV/hybrid.dmg
Creating hybrid image...

/Users/frederic/Documents/logs/fox/mozilla/build/package/mac_osx/pkg-dmg: exited on signal 6
/Users/frederic/Documents/logs/fox/mozilla/build/package/mac_osx/pkg-dmg: hdiutil makehybrid 
failed (cleaning up)
make[1]: *** [firefox-1.6a1.en-US.mac.dmg] Error 1
make: *** [all] Error 2"

Reopening ?

Comment 8

[Mark Mentovai]

hdiutil is abort()ing for some reason.  It's probably an Apple bug, but if we
know what conditions can put it into this state, we might be able to work around
it.  It would be helpful to get more information out of hdiutil.

Edit package/mac_osx/pkg-dmg to insert -verbose and -debug at line 875, so that
it looks like this:

if(command($gConfig{'cmd_hdiutil'}, 'makehybrid', '-verbose', '-debug', '-hfs',

(http://lxr.mozilla.org/mozilla/source/build/package/mac_osx/pkg-dmg#875)

If it fails, bring the new debugging output to this bug as an attachment.  If
you run it again on the same tree and it succeeds, debugging output from that
would be helpful too.  You might also consider filing a bug report with Apple
(bugreporter.apple.com).

Comment 9

[Frederic Bezies]

No problem this time at all. Maybe some modifications that happens on packager.mk (or something like 
that name) fixed the crash I was seeing. I will add soon the log in order to try to explain what happened ;)

Comment 10

[Frederic Bezies]

Attachment: debug log wanted.