305520 - GtkPromptService invalid warning on ConfirmEx with < 3 buttons

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Steps to reproduce:
0) run TestGtkEmbed
1) Go to http://[e-mail]/

Results:
WARNING: Unexpected button flags, file
/opt/source/mozilla/1.8-ff/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,
line 346

The 'unexpected' flag is 0. This happens when determining the label of the 3rd
button, and flags is 0 because there are only 2. nsIPromptService.idl for
ConfirmEx says "Puts up a dialog with up to 3 buttons and an optional, labeled
checkbox.", so this is NOT unexpected. Simple fix coming up.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 193456 [details] [diff] [review]
fix

only affects Gtk embedding

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

trunk:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.10; previous revision: 1.9
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.8.2.2; previous revision: 1.8.2.1
done