GtkPromptService invalid warning on ConfirmEx with < 3 buttons

RESOLVED FIXED

Status

Core Graveyard
Embedding: GTK Widget
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: Christian Persch (GNOME) (away; not receiving bug mail), Assigned: Christian Persch (GNOME) (away; not receiving bug mail))

Tracking

({fixed1.8})

Trunk
x86
Linux
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Steps to reproduce:
0) run TestGtkEmbed
1) Go to http://foo@gnome.org/

Results:
WARNING: Unexpected button flags, file
/opt/source/mozilla/1.8-ff/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,
line 346

The 'unexpected' flag is 0. This happens when determining the label of the 3rd
button, and flags is 0 because there are only 2. nsIPromptService.idl for
ConfirmEx says "Puts up a dialog with up to 3 buttons and an optional, labeled
checkbox.", so this is NOT unexpected. Simple fix coming up.
Created attachment 193456 [details] [diff] [review]
fix
Assignee: mpgritti → chpe
Status: NEW → ASSIGNED
Attachment #193456 - Flags: review?(mpgritti)

Updated

12 years ago
Attachment #193456 - Flags: review?(mpgritti) → review+
Attachment #193456 - Flags: superreview?(roc)
Comment on attachment 193456 [details] [diff] [review]
fix

only affects Gtk embedding
Attachment #193456 - Flags: superreview?(roc)
Attachment #193456 - Flags: superreview+
Attachment #193456 - Flags: approval1.8b5?

Updated

12 years ago
Attachment #193456 - Flags: approval1.8b5? → approval1.8b5+
trunk:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.10; previous revision: 1.9
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <-- 
GtkPromptService.cpp
new revision: 1.8.2.2; previous revision: 1.8.2.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.