305523 - Email preference for "CC changed" should be disabled by default for new users

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Shriramana Sharma]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050813 SeaMonkey/1.0a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050813 SeaMonkey/1.0a

On some bugs I've read that this request has been made many times before, but I
wasn't able to see this on any search. Ordinary people participating on
bugzilla.mozilla.org just sign up for an account and then start contributing.
But then when they are on the CC to a bug, and somebody else's CC gets added or
removed, then they (the first person) gets notified about it.

Totally unnecessary!

I have set my user preferences to send me notification when the CC field changes
*only* if I am the reporter of that bug. (It should be "if I am the reporter,
assignee or QA contact", but I do not write code, so don't become an assignee or
QA contact ever.)

This (reporter+assignee+QA) is how it should be by default. A lot of simple
people out there will be receiving unnecessary mail, and possibly don't know how
to stop it, just because somebody else visited bugs they also visited and signed
up as CC for.

Reproducible: Always

Steps to Reproduce:
1. Sign up for a new account on b.m.o.
2. Add yourself to the cc of a bug.
3. Wait.
Actual Results:  
I got many mails that told me that somebody else has gotten added to the same cc
or removed from the same cc as I am currently added to.

Expected Results:  
It should have switched off sending me mail due to CC change, except if I am
reporter, assignee, or QA contact for that bug.

Comment 1

[A. Karl Kornel]

Suggest confirming, but as an enhancement instead of a bug.

Comment 2

[Shriramana Sharma]

I changed this to enhancement (sorry for the lapse). Can we confirm and correct
this now? Shouldn't be too difficult?

Comment 3

[Gervase Markham [:gerv]]

This would be fixed in User.pm, around line 1175, where all email prefs are
turned on for new users. We would put code in the inner loop like this:

next if (($event == EVT_CC) && ($rel == REL_CC));

Dave: Sound like a good idea to you?

Gerv

Comment 4

[Olav Vitters]

Seems to be an regression from bug 109573 or bug 108870

Comment 5

[Gervase Markham [:gerv]]

Yep - I probably didn't check the defaults carefully enough when I checked in
the mail code rewrite. If this is a regression, then let's just fix it.

Looking at the old pref stuff, there's one other discrepancy. The old
"ExcludeSelf" was on by default, which means CHANGED_BY_ME should be off.

Gerv

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This makes the default prefs match those in the patch to bug 108870.

Gerv

Comment 7

[Max Kanat-Alexander]

Comment on attachment 194523 [details] [diff] [review]
Patch v.1

I doubt justdave will be able to take a look at this any time soon.

Comment 8

[Teemu Mannermaa (:wicked)]

Comment on attachment 194523 [details] [diff] [review]
Patch v.1

Tested on both 2.20 branch and trunk. Changes email preference defaults for new
users so that 1) all columns on "The change was made by me" row is selected and
2) only Reporter columns is selected on the "The CC field changes" row. Users
created from both editusers.cgi and createaccount.cgi seem to work.

Change is not effective for users created with Env login method, checksetup
created users (admin and others) and LDAP sync scripts in contrib. These never
had the defaults set in the first place.

Comment 9

[Dave Miller [:justdave]]

(In reply to comment #8)
> Change is not effective for users created with Env login method, checksetup
> created users (admin and others) and LDAP sync scripts in contrib. These never
> had the defaults set in the first place.

That's another bug (all user creation should be done in a central place).

Comment 10

[Frédéric Buclin]

gerv, this is a 2.20 blocker and we would like to start QA stuff asap; so I did
the checkin myself as this patch was awaiting checkin since the beginning of the
week.


tip:

Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.80; previous revision: 1.79
done

2.20rc2:

Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.61.2.6; previous revision: 1.61.2.5
done