305526 - Move publish code from resources into base

Status: RESOLVED DUPLICATE of bug 1710548

(Calendar :: General, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

Bug 285016 fixed publishing for calendar / sunbird, but it should be fixed for
lighting too. The code and UI can be moved into base/content.

Comment 1

[Joey Minta]

There already is some UI in base/content.  See bug 293710 for that aspect.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Unfortunately, I do not have cycles to work on Calendar stuff these days (just as it's getting to the good part!), so I am a bad owner for these bugs.  To delete the tragically-large chunk of bugspam, search for gregorianabdication.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v1

This patch basically copies over resources/content/publishDialog.js and resources/content/publishDialog.xul to base/content and replaces the code that is currently in base/content/calendar-publish-dialog.js and base/content/calendar-publish-dialog.xul

I left resources/content/publish.js out of this patch. For this I'll file a bug for a cvs copy resources/content/publish.js -> base/content/calendar-publish.js in case I get a positive review for the patch here.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'm against just moving over files from resources/ to base/content. I'd much rather see

* Code style fixes
* Clean up comments
* General overhaul

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #3)
> I left resources/content/publish.js out of this patch. For this I'll file a bug
> for a cvs copy resources/content/publish.js -> base/content/calendar-publish.js
> in case I get a positive review for the patch here.

Don't forget to change the openDialog() call in calendar-publish.js from publishDialog.xul to calendar-publish-dialog.xul.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 316982 [details] [diff] [review]
Patch v1

I won't have time for this review.

Comment 7

[Simon Paquet [:sipaq]]

(In reply to comment #4)
> I'm against just moving over files from resources/ to base/content. I'd much
> rather see
> 
> * Code style fixes
> * Clean up comments
> * General overhaul

Philipp, how do you propose that we go from here? Should I obsolete the patch? IMO moving the files over to calendar/base/content has value in itself, as it brings us closer to obsoleting calendar/resources/content/ which gets emptier every day.

Comment 8

[Martin Schröder [:mschroeder]]

Taking over. Simon, any objections?

Comment 9

[Simon Paquet [:sipaq]]

It's all yours.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Martin, whats the status of this bug? I'd like to get this one fixed as its low hanging fruit and the double code (base vs resources) just confused me. I can live with only a quick code style/comments cleanup for now.

Comment 11

[Markus Adrario [:Taraman]]

Martin, are you still on this?