305538 - Additional stuff required to make thebes go

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Stuart Parmenter]

This patch has some changes to nsIRenderingContext, nsIDeviceContext, some
widget stuff, views, etc.  Most of them are minor so I haven't split them out. 
This should be the last remaining patch to get thebes builds on the trunk.

Comment 1

[Stuart Parmenter]

Attachment: The Rest

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

 NS_IMETHODIMP nsRenderingContextOS2::RetrieveCurrentNativeGraphicData(PRUint32*
ngd)
 {
-  if(ngd != nsnull)
-    *ngd = (PRUint32)mPS;
+  *ngd = (void*)mPS;
   return NS_OK;
 }
...
+  NS_IMETHOD RetrieveCurrentNativeGraphicData(void** aNativeData);

This is messed up. I think you want a different signature here.

Comment 3

[Stuart Parmenter]

Attachment: fix os2 and some windows stuff that didn't migrate properly

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 193520 [details] [diff] [review]
fix os2 and some windows stuff that didn't migrate properly

good to go, with DrawNativeWidgetPixmap removed as discussed on IRC

Comment 5

[Stuart Parmenter]

checked in

Comment 6

[Sergei Dolgov]

BeOS build bustage by
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsRenderingContextBeOS.cpp&rev1=1.51&rev2=1.52&root=/cvsroot
Pavlov's checkin.

Way to fix:
NS_IMETHODIMP nsRenderingContextBeOS::RetrieveCurrentNativeGraphicData(PRUint32
*ngd) declaration must be removed from
mozilla/widget/src/beos/nsRenderingContextBeOS.h

Comment 7

[Doug Shelton]

Attachment: patch file implementing sergei's fix

Comment 8

[Doug Shelton]

Attachment: patch file implementing sergei's fix

Comment 9

[Stuart Parmenter]

checked in fix for beos.

Comment 10

[Doug Shelton]

Comment on attachment 194384 [details] [diff] [review]
patch file implementing sergei's fix

seen next attachment

Comment 11

[Sergei Dolgov]

Probably we need to add also something like
NATIVE_BEOS_VIEW = 6 to nsIRenderingContext
 and implement GetNativeGraphicData() in nsRenderingContextBeOS

Comment 12

[Steffen Wilberg]

Comment on attachment 194385 [details] [diff] [review]
patch file implementing sergei's fix

The BeOS bustage fix has been checked in by pavlov, so removing review requests.

Comment 13

[Doug Shelton]

(In reply to comment #12)
> (From update of attachment 194385 [details] [diff] [review])
> The BeOS bustage fix has been checked in by pavlov, so removing review
> requests.
> 
Thank you!