Closed Bug 305538 Opened 19 years ago Closed 19 years ago

Additional stuff required to make thebes go

Categories

(Core Graveyard :: GFX, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pavlov, Assigned: pavlov)

Details

Attachments

(2 files, 2 obsolete files)

This patch has some changes to nsIRenderingContext, nsIDeviceContext, some
widget stuff, views, etc.  Most of them are minor so I haven't split them out. 
This should be the last remaining patch to get thebes builds on the trunk.
Attached patch The Rest (obsolete) — Splinter Review
Attachment #193477 - Flags: superreview?(roc)
Attachment #193477 - Flags: review?(vladimir)
 NS_IMETHODIMP nsRenderingContextOS2::RetrieveCurrentNativeGraphicData(PRUint32*
ngd)
 {
-  if(ngd != nsnull)
-    *ngd = (PRUint32)mPS;
+  *ngd = (void*)mPS;
   return NS_OK;
 }
...
+  NS_IMETHOD RetrieveCurrentNativeGraphicData(void** aNativeData);

This is messed up. I think you want a different signature here.
Attachment #193477 - Attachment is obsolete: true
Attachment #193520 - Flags: superreview?(roc)
Attachment #193520 - Flags: review?(vladimir)
Comment on attachment 193520 [details] [diff] [review]
fix os2 and some windows stuff that didn't migrate properly

good to go, with DrawNativeWidgetPixmap removed as discussed on IRC
Attachment #193520 - Flags: superreview?(roc) → superreview+
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
BeOS build bustage by
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/gfx/src/beos&command=DIFF_FRAMESET&file=nsRenderingContextBeOS.cpp&rev1=1.51&rev2=1.52&root=/cvsroot
Pavlov's checkin.

Way to fix:
NS_IMETHODIMP nsRenderingContextBeOS::RetrieveCurrentNativeGraphicData(PRUint32
*ngd) declaration must be removed from
mozilla/widget/src/beos/nsRenderingContextBeOS.h
Attachment #194385 - Flags: superreview?(acarder)
Attachment #194385 - Flags: review?(ap)
checked in fix for beos.
Comment on attachment 194384 [details] [diff] [review]
patch file implementing sergei's fix

seen next attachment
Attachment #194384 - Attachment is obsolete: true
Probably we need to add also something like
NATIVE_BEOS_VIEW = 6 to nsIRenderingContext
 and implement GetNativeGraphicData() in nsRenderingContextBeOS
Comment on attachment 194385 [details] [diff] [review]
patch file implementing sergei's fix

The BeOS bustage fix has been checked in by pavlov, so removing review requests.
Attachment #194385 - Flags: superreview?(acarder)
Attachment #194385 - Flags: review?(ap)
(In reply to comment #12)
> (From update of attachment 194385 [details] [diff] [review])
> The BeOS bustage fix has been checked in by pavlov, so removing review
> requests.
> 
Thank you!

Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: