305543 - network.dnsCacheEntries and network.dnsCacheExpiration missing from about:config

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[kenny]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

network.dnsCacheEntries and network.dnsCacheExpiration . were both missing when
i checked the about:config in the address bar.i added them manually , and they
seem to be working. iwas not losing my cable connection but iwas having a
timming out problem,eversince i downloaded the latest firefox1.0.6. i was not
having problem with older versions.i hope this repaired it  ,kenny

Reproducible: Sometimes

Steps to Reproduce:

2.
3.

Actual Results:  
connection timmed out for about 1 or 2 tries

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The default values of those prefs (hardwired in
network/dns/src/nsDNSService2.cpp) are 20 cache entries and 1 minute expiration.
What settings did you use ?

Comment 2

[kenny]

i used the dfault settings 20 cache and 60 seconds 

Comment 3

[Jo Hermans]

Reporter, if those entries were not in about:config, we're using the default
values. See
<http://lxr.mozilla.org/seamonkey/source/netwerk/dns/src/nsDNSService2.cpp#293>.
The defaults haven't been changed since 2003 (bug 223861).

Comment 4

[Henrik Gemal]

we should add the following to the default prefs.js file:

pref("network.dnsCacheEntries", 20);
pref("network.dnsCacheExpiration", 1);

Comment 5

[Henrik Gemal]

Attachment: add the missing entries to all.js

Comment 6

[benc]

Two things:

if you are going to modify all.js, this is a core:networking bug, not a firefox bug.

The expiration value is wrong. The feature operates on a per-minute-basis, but the preference, for some reason, is in seconds:

314         if (NS_SUCCEEDED(prefs->GetIntPref(kPrefDnsCacheExpiration, &val)))
315             maxCacheLifetime = val / 60; // convert from seconds to minutes

based on my very weak C++ code reivew, I also believe that if you do not put seconds in increments that form a minute, they the lifetime value will be effectivly rounded down. If someone can confirmt that, I'll clarify that in the  network prefs docs as well.

Comment 7

[benc]

Comment on attachment 202352 [details] [diff] [review]
add the missing entries to all.js


>+// DNS cache lifttime in minutes
>+pref("network.dnsCacheExpiration", 1);

This should be "seconds" and the value should be "60".

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

And also not "lifttime", but "lifetime"...

Comment 9

[Mike Connor [:mconnor]]

This isn't a big deal, clearing nom and moving to core networking.

Comment 10

[benc]

I have checkin privs, so, if someone wants to help me out, I can do the legwork.

Comment 11

[Balaji Kamal Kannadassan]

I have been using for one of feature to modify this via the XPConnect in JavaScript. Now since the entry is not there I am getting exception. Will you be adding this back into the about:config ?. If not is there any other way I can create these extensions via JavaScript ?. This has made a major set back for me on my development of the script, which is put into a signed jar and downloaded & executed at the client side. It would be helpful if I could get some response on the same at the earliest.

Thanks
Balaji

Comment 12

[benc]

I'll have to get caught up on the new code management system this week.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

irc.mozilla.org/#hg can help, if you have any questions not covered by the Mercurial FAQ on MDC ( http://developer.mozilla.org/en/Mercurial_FAQ ).

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Balaji, you can just set the prefs using the pref API and then they'll appear in about:config, etc.

Comment 15

[Balaji Kamal Kannadassan]

Hi Christian!

   Thanks for the response it worked fine, on setting and could see it appearing back. But this worked fine with 2.0.0.11, when I tried with 3.0 it was a problem. When 2.0.0.11 updated, thats mozilla did an update to 2.0.0.17 it worked fine, but when I installed 2.0.0.17 / 3.0 afresh setting threw exception and setting manually never worked as well. Looks like something has been missing from 2.0.0.11 - 2.0.0.17 installation.

Thanks
Balaji Kamal Kannadassan