305548 - Starting a drag of a mail message loads the message only partially

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

regression from 1.7.x, unfortunately I have no idea when it hapepned

When I start a drag of a message, it loads partially: The title bar of the mail
window changes as well as as the pane that shows subject/from/attachments/etc.
But the message pane does not show the new message.

In 1.7.x this showed the message.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

(linux gtk2 seamonkey, current cvs but is not a recent regression)

Comment 2

[zug_treno]

Reproducible with SeaMonkey/20050821 but WFM with Mozilla 1.8b1.

Comment 3

[Andrew Schultz]

I get: ###!!! ASSERTION: can't get drag session: 'mSlots->mDragSession', file
/build/andrew/moz-debug/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp,
line 1897

this regressed between linux suite trunk builds 2005022705 and 2005022801,
perhaps bug 125386

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I debugged this for a while. I got as far as finding out that the call to
docShell->LoadURI to load the message here:
http://lxr.mozilla.org/mozilla/source/mailnews/local/src/nsMailboxService.cpp#210
does still fire.

Comment 5

[[e-mail]]

(In reply to comment #3)
>I get: ###!!! ASSERTION: can't get drag session: 'mSlots->mDragSession', file
>/build/andrew/moz-debug/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp,
>line 1897
Fixed by attachment 194462 [details] [diff] [review].

Comment 6

[Boris Zbarsky [:bzbarsky]]

So is this bug still an issue?

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

yes, it is.

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK.  So the assert is gone, but the bug is not?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

dunno about the assert (I use opt builds for reading mail); but the bug is definitely still there.

Comment 10

[Tony Mechelynck [:tonymec]]

Comment #4: IIUC that line is now at http://lxr.mozilla.org/mozilla/source/mailnews/local/src/nsMailboxService.cpp#275

Comment #5: Attachment 194462 [details] [diff] belongs to bug 269568 which has been REOPENED after that patch was found not to fix it. I think the patch has not been rolled back but I'm not 100% sure.

Christian: sorry for bothering you, do you still see this, 2½ years after you told Boris that you did? (I don't.)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2008071201 SeaMonkey/2.0a1pre

Comment 11

[Andrew Schultz]

I still see this in a build from Jan 2006, but not Jan 2007 (or current trunk)

resolving WFM

Comment 12

[[e-mail]]

I seem to remember some drag and drop changes that might have fixed this.

Comment 13

[Tony Mechelynck [:tonymec]]

(In reply to comment #11)
> I still see this in a build from Jan 2006, but not Jan 2007 (or current trunk)
> 
> resolving WFM
> 

(In reply to comment #12)
> I seem to remember some drag and drop changes that might have fixed this.
> 

So much the better then. Unless the bug for those changes suddenly surfaces, I suppose this one can remain WFM (barring new sightings of course).