305564 - CSS parsing errors when <object> with missing plugin does not have width/height attributes

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050822
Firefox/1.0+

Steps to reproduce:
1. Load data:text/html,<object type="application/wtf"
data="http://www.google.com/images/logo.gif">6</object>

Result:
"Error parsing value for property 'height'." and
"Error parsing value for property 'width'." in the JavaScript console (sometimes
twice).

Comment 1

[Jesse Ruderman]

If you add a width attribute to the <object>, "Error parsing value for property
'width'." goes away, and similarly for height.

Comment 2

[Jesse Ruderman]

Commenting out the stuff in SizeAnchor in nsObjectFrame.cpp (called by
nsObjectFrame::Reflow) fixes the warnings.  I haven't figured out why, though.

Comment 3

[Jesse Ruderman]

roc, want this bug?

Comment 4

[Jesse Ruderman]

This might have been fixed by the checkin for bug 1156, specifically this hunk:
 
   nsAutoString tmp;
   tmp.AppendInt(aWidth);
-  AppendASCIItoUTF16("px", tmp);
+  tmp.AppendLiteral("px");
+
   css2props->SetWidth(tmp);
 
   tmp.Truncate();
   tmp.AppendInt(aHeight);
-  AppendASCIItoUTF16("px", tmp);
+  tmp.AppendLiteral("px");
+
   css2props->SetHeight(tmp);

I can't test until bug 309521 is fixed.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I can't imagine that that change makes any difference.

but that code will go away anyway.

why is this now security-sensitive?

Comment 6

[Jesse Ruderman]

Oops, I must have clicked the "Security-Sensitive Bug" checkbox accidentally.

Comment 7

[Boris Zbarsky [:bzbarsky]]

All that happened was that the C++ generated invalid CSS.  Since we're no longer doing that, this should be fixed (by bug 1156), though if you want to wait till bug 309521 is fixed to verify, go for it.

Comment 8

[Jesse Ruderman]

WFM Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060102 Firefox/1.6a1

Btw, I never see plugin finder activate for <object> on trunk.  It's just replaced by its alternate content, even if it's empty.  Plugin finder does appear for <embed>.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed by bug 1156 / bug 309521

pluginfinder requires a pluginurl being present. was that different in 1.0.x?

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

(I tried to match the conditions used for showing the (pre-pluginfinder) nullplugin)