305577 - lightning prefs tab has 8 icons

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Dietrich Ayala (:dietrich)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

i compiled lightning on mac osx 10.4.2
installed tbird nightly from 8/21
installed lightning extension
go to tbird prefs
the lightning prefs area is a single clickable area w/ 8 icons (see screenshot url)

http://dietrich.ganx4.com/images/osx_lightning_prefs_bug.png

Reproducible: Always

Steps to Reproduce:
i compiled lightning on mac osx 10.4.2
installed tbird nightly from 8/21
installed lightning extension
go to tbird prefs

Actual Results:  
the lightning prefs area is a single clickable area w/ 8 icons

Expected Results:  
lightning prefs should not cover the other 7 icons

Comment 1

[Joey Minta]

Attachment: specify an icon

Without a style rule, the entire thunderbird icon rule applies.  This patch
specifies an icon to use.  I found the nice calendartoolbar.png in
calendar/resources/skin/ and it seems to work fairly well here.  Are there any
problems with just using it? (I don't know who created it, but I think Mark
Carson has copyrights on many of the icons in calendar/)  If we can't use this
icon, we should work on getting something to put there.

(Note: jar.mn changes untested)

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Mostafa checked that file in originally, so I'm hoping he knows the copyright
ownership on the file (and what license contraints it has, if any).

Comment 3

[Mostafa Hosseini]

I doubt that when I checked in the file which came from this attachment:
http://bugzilla.mozilla.org/show_bug.cgi?id=219589#c7
that I paid attention to its copyright.
I will cc Eric Belhaire who provided the file to see if he knows.

In general, regarding copyright on calendar files, they should all be
tri-licensed. The original files from oeone were tri-licensed and the sunbird
theme files and icons that followed should be tri-licensed as well.
It was clearly stated when the call for a new theme was announced:

http://forums.mozillazine.org/viewtopic.php?t=85054

Noone can claim copyright on any of those files.

Comment 4

[Eric Belhaire]

(In reply to comment #3)
> I will cc Eric Belhaire who provided the file to see if he knows.
> 
I think the icon belongs to an old Theme of the Evolution project
(http://www.gnome.org/projects/evolution). I can't find the copyright now.

Comment 5

[Mark Carson]

All of the icons for the default Sunbird theme are MPL/GPL/LGPL licensed (some I
made, others are re-used from Firefox). Please don't forget that these licenses
exist to allow use of copyrighted material. Without copyright, the mighty GPL
would have no legal basis.

There are trademark issues with the Sunbird logo which Gervase Markham is
coordinating.

Mark Carson
0725/11-OCT-2005
[e-mail]

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 197347 [details] [diff] [review]
specify an icon

r=dmose

Comment 7

[Joey Minta]

patch checked in