305604 - Scaled images 1px wide and very tall disappear and can't be enlarged

Status: NEW

(SeaMonkey :: UI Design, defect)

Description

[dolphinling]

If you view an image that has one very short and one very long dimension (say,
1px by 10000px), the 1px gets rounded down to 0 and the image disappears, with
nowhere to click to enlarge it.

Don't know where to file this, but layout: images can't be *too* far off the mark.

Testcase coming.

Comment 1

[dolphinling]

Attachment: Testcase: 1x10000px image

Comment 2

[Frank Wein [:mcsmurf]]

Just wondering do you see nothing or only some pixels? The testcase you attached
is just a image 10000px high (with some black and red pixels more at the top),
but not a black/red/whatever line 10000px high.

Comment 3

[Mats Palmgren (inactive)]

If you have the "Resize large images to fit the browser window" pref on - then
you will not see anything, since the width has been scaled to zero.
I think the reporter's request is reasonable for other reasons too.
When *viewing an image* I think it makes sense if the background activates
the image context menu also in areas where the image is not painted.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Something like this?

Comment 5

[dolphinling]

(In reply to comment #2)

Sorry, I just ripped the image off the site I first saw it on. The bug also
happens with a solid black image.

(In reply to comment #3)

Mats, ideally I should be able to use a normal single click to enlarge, just
like I'm used to (especially if I'm a normal user). Would it make sense to make
the whole canvas sensitive to that, too?

Comment 6

[Mats Palmgren (inactive)]

(In reply to comment #5)
> Mats, ideally I should be able to use a normal single click to enlarge, just
> like I'm used to (especially if I'm a normal user). Would it make sense to
> make the whole canvas sensitive to that, too?

Sure, I think it would be good if someone with more experience with end-user
GUI stuff could say what is desirable before working on this further though.

It occurred to me after I attached the patch that the context menu is now
missing "Back" "Reload" "Bookmark..." etc that is not available on the
regular image context menu, so we should probably add those also for example.

Comment 7

[[e-mail]]

I agree that the entire canvas should act as a standalone image.
It seems to me that all that is necessary is to separate the standalone image
detection code from the image detection code.
I'm not sure whether the standalone image detection code should set onImage or
whether all the other uses of onImage should be fixed up.

Comment 8

[dolphinling]

So, the bug as reported is now WFM. However, do we want to morph it into something like "Make entire viewport sensitive to clicks for image resize" or something? It's still *hard* to enlarge them, because you have to get your mouse over just the right pixel (in the X direction). 

Comment 9

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".