305611 - "Currently selected day" filter does nothing

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Marcin Kost]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8b4) Gecko/20050818 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050822 Mozilla Sunbird/0.2+

Choosing the option "Currently selected day" from the Events preview listbox
does nothing at the moment, the list of events remains the same.

Reproducible: Always

Steps to Reproduce:
1. Create several new events occuring on different days.
2. Select one day either by using the main view or the mini calendar.
3. Choose the "Currently selected day" option from the list

Actual Results:  
Nothing changes, the list of events remains the same as with the previously used
option.

Expected Results:  
The preview should only show the events occuring on the day selected in the main
view or in the mini calendar.

Comment 1

[Robin Edrenius]

Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1)
Gecko/20050823 Mozilla Sunbird/0.2+

I get this error in the JS-console:
Error: MidnightSelectedDate is not defined
Source File: chrome://calendar/content/unifinder.js
Line: 656

Comment 2

[Joey Minta]

Attachment: use StartDate instead

StartDate is already set for midnight on the selected day, so this patch just
uses it instead.

Comment 3

[Robin Edrenius]

Attachment: Fix 'Currently Selected day'

This fixes it for me, I'm not sure this is the way you wan't it fixed though.

Comment 4

[Robin Edrenius]

(In reply to comment #2)
> Created an attachment (id=193573) [edit]
> use StartDate instead
> 
> StartDate is already set for midnight on the selected day, so this patch just
> uses it instead.

Oh, sorry, was writing and didn't refresh just before posting.

Comment 5

[Joey Minta]

Comment on attachment 193575 [details] [diff] [review]
Fix 'Currently Selected day'

We both did it the same way, so I hope it's right.

r=jminta

Also, you have canconfirm, so you should change status to 'New' when
confirming.

Comment 6

[Joey Minta]

patch checked in.