30562 - [FIXED] Message loses linefeeds when quoted

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Richard Zach]

I'm attaching a message which I found on n.p.m.general.  When I reply to the
message, the quoted text is all run together, the CR/LFs of the original are
gone.  The original message had no Content-Type header, and I tried putting one
in (with text and tex/plain), but the result was the same.  I haven't seen this
on any other message.

Linux build 2000.03.04.09

Comment 1

[Richard Zach]

Attachment: Message which loses lineffeds when quoted

Comment 2

[Jean-Francois Ducarroz]

Richard, I suppose your are using an HTML message compose window?

Comment 3

[Richard Zach]

Sorry: no, this is plain text compose.

Comment 4

[Jean-Francois Ducarroz]

reassign to rhp. It's maybe a dup of a bug rich fixed recently about parsing the 
body for entities in plain text!

Comment 5

[Jean-Francois Ducarroz]

*** Bug 30935 has been marked as a duplicate of this bug. ***

Comment 6

[Akkana Peck]

This is a regression -- I see it in a 3/6 build, but not in a 3/3 build.

The messages which trigger this tend to use ">" (no space after it) or "* " or
similar characters for quoting.

Is it possible that the html conversion code is somehow kicking in?  Did it
change recently?  Adding Ben just in case.

Comment 7

[Akkana Peck]

This makes plaintext mail basically unusable for real-world conversations, so
I've moved the beta1 and regression keywords from bug 30935 (which was duped).

Something is wrapping the quoted text before it's passed to
nsHTMLEditor::InsertAsPlaintextQuotation.

Comment 8

[Ben Bucksch (:BenB)]

Doesnt happen on my build from 2000-02-29, but with my perf changes, so it's not
mine, dunno about mscott's changes. I assume, I could see the bug already in the
editor.

Comment 9

[Akkana Peck]

I downloaded a bunch of release builds and tried them to narrow this down.  The
regression happened between the 3-3-16 build and the 3-4-09 build.

Comment 10

[Phil Peterson]

[PDT+] w/b minus on 3/10

Comment 11

[rhp (gone)]

Guys...don't worry, I'll figure it out...just give me a little time :-)

- rhp

Comment 12

[rhp (gone)]

Ok, this seems to work fine in my tree, but I have some bug fixes for both mime 
and compose in my code. The ones I think may be affecting this are the mime 
changes I have. If anyone can give these a try in their build, it would be 
great. In the mean time, I will back out the changes to my tree and see if the 
problem shows up for me.

- rhp

Comment 13

[rhp (gone)]

Ok, I have this fixed. Actually, Ben's updates and my fixes to those updates 
address these problems. I backed out the changes and saw the problem then 
reapplied the changes and it worked.

Attached is the patch that fixes it.

- rhp

Comment 14

[Ben Bucksch (:BenB)]

I /think/, rhp is speaking about the patch for bug #27199.

Comment 15

[Ben Bucksch (:BenB)]

Correction: bug #27991

Comment 16

[rhp (gone)]

Attachment: This fixes the problem

Comment 17

[rhp (gone)]

This is fixed.

- rhp

Comment 18

[laurel]

OK using:
2000-03-09-13m15 commercial build linux rh6.0
2000-03-09-10m15 commercial build mac OS 9.0
2000-03-09-14m15 commercial build NT 4.0