Closed Bug 305624 Opened 19 years ago Closed 19 years ago

[FIX][@ nsContentUtils::Shutdown]

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta4

People

(Reporter: timeless, Assigned: bzbarsky)

References

(
URL
)

Details

(Keywords: crash, fixed1.8)

Crash Data

Attachments

(2 files)

Fix
1.31 KB, patch
Details | Diff | Splinter Review
Same as diff -w
1.09 KB, patch
jst
: review+
jst
: superreview+
asa
: approval1.8b4+
Details | Diff | Splinter Review 
Incident ID: 8605646
Stack Signature	nsContentUtils::Shutdown 74f68e24
Product ID	MozillaTrunk
Build ID	2005082205
Trigger Time	2005-08-22 08:19:40.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	gklayout.dll + (000e0598)
URL visited	
User Comments	
Since Last Crash	0 sec
Total Uptime	1 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsContentUtils.cpp,
line 449
Stack Trace 	
nsContentUtils::Shutdown 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsContentUtils.cpp,
line 449]
nsGenericModule::Initialize 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsGenericFactory.cpp,
line 273]
nsGenericModule::GetClassObject 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsGenericFactory.cpp,
line 361]
nsNativeComponentLoader::GetFactoryFromModule 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsNativeComponentLoader.cpp,
line 1058]
nsNativeComponentLoader::GetFactory 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsNativeComponentLoader.cpp,
line 160]
nsFactoryEntry::GetFactory 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.h,
line 302]
nsComponentManagerImpl::CreateInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.cpp,
line 1897]
CallCreateInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsComponentManagerUtils.cpp,
line 158]
nsTypeAheadFind::Init 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp,
line 190]
nsTypeAheadFind::GetInstance 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/extensions/typeaheadfind/src/nsTypeAheadFind.cpp,
line 230]
nsComponentManagerImpl::GetServiceByContractID 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/components/nsComponentManager.cpp,
line 2410]
CallGetService 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/build/nsComponentManagerUtils.cpp,
line 95]
nsAppStartupNotifier::Observe 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/embedding/components/appstartup/src/nsAppStartupNotifier.cpp,
line 99]
main1 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1059]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1738]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1762]
kernel32.dll + 0x16d4f (0x7c816d4f)
Attached patch Fix — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Same as diff -w
        — 
          — Splinter Review
      

    


  

        Attachment #193577 -
        Flags: superreview?(jst)

        Attachment #193577 -
        Flags: review?(jst)

    
  
Priority: -- → P1
Summary: [@ nsContentUtils::Shutdown] → [FIX][@ nsContentUtils::Shutdown]
Target Milestone: --- → mozilla1.8beta4

    
    

    
  
As timeless pointer out, we should null the pointer out after the delete there.

    
    

    
  
Comment on attachment 193577 [details] [diff] [review]
Same as diff -w

r+sr=jst

        Attachment #193577 -
        Flags: superreview?(jst)

        Attachment #193577 -
        Flags: superreview+

        Attachment #193577 -
        Flags: review?(jst)

        Attachment #193577 -
        Flags: review+

    
    

    
  
Comment on attachment 193577 [details] [diff] [review]
Same as diff -w

requesting branch approval; just a null-check that can prevent crashes.

        Attachment #193577 -
        Flags: approval1.8b4?

    
    

    
  
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
  
Flags: blocking1.8b4+

    
  

        Attachment #193577 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
Fixed on branch.
Keywords: fixed1.8
Crash Signature: [@ nsContentUtils::Shutdown]

    
  
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: