Closed Bug 305628 Opened 19 years ago Closed 15 years ago

Additional improvements to jsfile.c

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mrbkap, Unassigned)

Details

Attachments

(3 obsolete files) 

My checkin for bug 132949 fixed a few issues with jsfile.c, but there are more
to bee found. I'm filing this as a holding pen for patches to jsfile.c, since I
won't be looking at this file too much, I don't think there will be too many.
Attached patch fix stupid OOM leak (obsolete) — — Splinter Review 

  

  



        Attachment #193578 -
        Flags: review?(shaver)

    
    

    
  
Comment on attachment 193578 [details] [diff] [review]
fix stupid OOM leak

r+a=shaver

  

  



        Attachment #193578 -
        Flags: review?(shaver)

        Attachment #193578 -
        Flags: review+

    
    

    
  
Attachment 193578 [details] [diff] has been checked in.

  

  


Flags: testcase-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix more issues (obsolete)
        — 
          — Splinter Review
      

    


  
This fixes an iloop on Windows, several leaks in canonicalPath, a bunch of style nits, and a bug pointed out by jb@bevemyr.com. There are still more bugs to patch here, but this is a start.

  

  



        Attachment #200658 -
        Flags: review?(shaver)

    
    

    
  
Comment on attachment 200658 [details] [diff] [review]
fix more issues

This isn't part of any official build, but embedders are going to want it.

  

  



        Attachment #200658 -
        Flags: approval1.8rc1?

    
    

    
  
Comment on attachment 200658 [details] [diff] [review]
fix more issues

rs=shaver

  

  



        Attachment #200658 -
        Flags: review?(shaver) → review+

    
    

    
  
Comment on attachment 200658 [details] [diff] [review]
fix more issues

This is not part of any product build.

/be

  

  



        Attachment #200658 -
        Flags: approval1.8rc1? → approval1.8rc1+

    
    

    
  
Putting on the radar to sneak some additional fixes into rc2 (if there is one!).

  

  


Flags: blocking1.8rc1?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Sync up the branch and trunk (obsolete)
        — 
          — Splinter Review
      

    


  
This NPOTB fix is for embedders only.

  

  



        Attachment #193578 -
        Attachment is obsolete: true

        Attachment #200658 -
        Attachment is obsolete: true

        Attachment #201047 -
        Flags: approval1.8rc1?

    
    

    
  
moving out to the rc2 ride-along list.

  

  


Flags: blocking1.8rc1? → blocking1.8rc2?

    
  

        Attachment #201047 -
        Flags: approval1.8rc1? → approval1.8rc2+

    
    

    
  
Comment on attachment 201047 [details] [diff] [review]
Sync up the branch and trunk

Checked in.

  

  



        Attachment #201047 -
        Attachment is obsolete: true

    
    

    
  
Clearing the blocking request since this is now sync'ed up with the trunk: no more fixes will be making the 1.8 branch.

  

  


Flags: blocking1.8rc2?

    
    

    
  
This is already in the ff15 release, removing js16 bug 309169 blocking.

  

  


No longer blocks: js1.6rc1

    
  
Assignee: mrbkap → general

    
  
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: