Additional improvements to jsfile.c

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: mrbkap, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 obsolete attachments)

(Reporter)

Description

13 years ago
My checkin for bug 132949 fixed a few issues with jsfile.c, but there are more
to bee found. I'm filing this as a holding pen for patches to jsfile.c, since I
won't be looking at this file too much, I don't think there will be too many.
(Reporter)

Comment 1

13 years ago
Created attachment 193578 [details] [diff] [review]
fix stupid OOM leak
Attachment #193578 - Flags: review?(shaver)
Comment on attachment 193578 [details] [diff] [review]
fix stupid OOM leak

r+a=shaver
Attachment #193578 - Flags: review?(shaver)
Attachment #193578 - Flags: review+
(Reporter)

Comment 3

13 years ago
Attachment 193578 [details] [diff] has been checked in.
Flags: testcase-
(Reporter)

Comment 4

13 years ago
Created attachment 200658 [details] [diff] [review]
fix more issues

This fixes an iloop on Windows, several leaks in canonicalPath, a bunch of style nits, and a bug pointed out by jb@bevemyr.com. There are still more bugs to patch here, but this is a start.
Attachment #200658 - Flags: review?(shaver)
(Reporter)

Comment 5

13 years ago
Comment on attachment 200658 [details] [diff] [review]
fix more issues

This isn't part of any official build, but embedders are going to want it.
Attachment #200658 - Flags: approval1.8rc1?
Comment on attachment 200658 [details] [diff] [review]
fix more issues

rs=shaver
Attachment #200658 - Flags: review?(shaver) → review+
Comment on attachment 200658 [details] [diff] [review]
fix more issues

This is not part of any product build.

/be
Attachment #200658 - Flags: approval1.8rc1? → approval1.8rc1+
(Reporter)

Comment 8

13 years ago
Putting on the radar to sneak some additional fixes into rc2 (if there is one!).
Flags: blocking1.8rc1?
(Reporter)

Comment 9

13 years ago
Created attachment 201047 [details] [diff] [review]
Sync up the branch and trunk

This NPOTB fix is for embedders only.
Attachment #193578 - Attachment is obsolete: true
Attachment #200658 - Attachment is obsolete: true
Attachment #201047 - Flags: approval1.8rc1?

Comment 10

13 years ago
moving out to the rc2 ride-along list.
Flags: blocking1.8rc1? → blocking1.8rc2?

Updated

13 years ago
Attachment #201047 - Flags: approval1.8rc1? → approval1.8rc2+
(Reporter)

Comment 11

13 years ago
Comment on attachment 201047 [details] [diff] [review]
Sync up the branch and trunk

Checked in.
Attachment #201047 - Attachment is obsolete: true
(Reporter)

Comment 12

13 years ago
Clearing the blocking request since this is now sync'ed up with the trunk: no more fixes will be making the 1.8 branch.
Flags: blocking1.8rc2?
This is already in the ff15 release, removing js16 bug 309169 blocking.
No longer blocks: 309169
(Reporter)

Updated

9 years ago
Assignee: mrbkap → general

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.