305659 - Typo in nsBrowserContentHandler.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jeff Walden [:Waldo]]

The QueryInterface method of the module in nsBrowserContentHandler.js should
check if the passed IID is nsISupports or nsIModule, but instead it checks if
the passed IID is *both* nsISupports and nsIModule, which clearly will never happen.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 193600 [details] [diff] [review]
Patch

That's pretty impressive... how does this actually work?

Comment 3

[Jeff Walden (gone starting June 8)]

(In reply to comment #2)
> (From update of attachment 193600 [details] [diff] [review] [edit])
> That's pretty impressive... how does this actually work?

Presumably no one's ever attempting to QI the module to anything, and they're
just assuming it implements the nsIModule interface.  Anyway, patch checked in,
marking FIXED...

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 193600 [details] [diff] [review]
Patch

It's been suggested that I ask for branch approval for this patch.  It's
low-risk and fixes behavior that's clearly broken, so it's definitely
branch-quality material.

Comment 5

[Jeff Walden [:Waldo]]

Patch checked in on 1.8 branch.