305665 - Should not reference extensions/spellcheck/myspell/dictionaries in allmakefiles.sh

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

Bug 295465 removed extensions/spellcheck/myspell/dictionaries and placed
dictionaries in extensions/spellcheck/locales.  allmakefiles.sh was never
updated to reflect the change.  It still attempts to transform the old
nonexistent Makefile in dictionaries, and doesn't know about the new one in locales.

This is causing periodic problems checking out on certain machines by preventing
cvs from updating the source tree fully.  It caused a lot of burning on pawn
(Camino trunk).  For example:
http://tinderbox.mozilla.org/showlog.cgi?log=Camino/1124815080.2330.gz&fulltext=1
.  Apparently, some versions of cvs are better than others at recovering from
directories in the local tree that aren't present in the repository.

Related to bug 301969?

Comment 1

[Mark Mentovai]

Attachment: Fix allmakefiles.sh

This also fixes tools/module-deps/module2dir.map.  I'm not certain when that
file is used (it's a dependency map), but it's the only other spot I see in lxr
that the nonexistent directory is referenced.

Comment 2

[Mark Mentovai]

pink fixed the Camino tinderbox by removing

--enable-extensions=all

and whacking the offending (and offensive) directory.

Comment 3

[Mark Mentovai]

Fixed, trunk and branch.