Closed Bug 305679 Opened 19 years ago Closed 19 years ago

please look before leaping for mimeInfo.primaryExtension

Categories

(SeaMonkey :: UI Design, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

Attachments

(1 obsolete file)

Error ``mimeInfo has no properties'' [xs] in file
``chrome://communicator/content/contentAreaUtils.js'', line 893, character 0.
Stopped for error handler.
#0: function getDefaultExtension(aFilename=string:"redirhard.php",
aURI=XPComponent:{12}, aContentType=null:null) in
<chrome://communicator/content/contentAreaUtils.js> line 893
891: else {
892: try {
893: return mimeInfo.primaryExtension;

0002: mimeInfo
$[0] = [null] null
Attached patch look before leaping (obsolete) β€” β€” Splinter Review
Assignee: guifeatures → timeless
Status: NEW → ASSIGNED
Attachment #193629 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #193629 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 193629 [details] [diff] [review]
look before leaping

BTW on the previous patch I reviewed I forgot to notice that catch (e) { }
isn't file style and you need to fix the } to go on its own line as
demonstrated here.
Attachment #193629 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #193629 - Flags: superreview+
Attachment #193629 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #193629 - Flags: review+
Did this ever get checked in?
Comment on attachment 193629 [details] [diff] [review]
look before leaping

mozilla/xpfe/communicator/resources/content/contentAreaUtils.js 	1.135
Attachment #193629 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: