305686 - Localized Mac builds need EULA and updated packaging

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Mentovai]

l10n follow-up to bug 302080.  Localized Mac builds need an EULA.  Because only
en and jp EULAs exist, and because the other platforms currently only display
the English EULA, the general consensus seems to be to go with English.  No l10n
impact.

This will also bring the disk image icons and backgrounds from bug 283598 to
localized builds.  A new textless disk image background is being designed in
that bug.

Comment 1

[Chris Beard]

We should use the English EULA for all builds as this is the official legal text
which then references and provides links to localizations (as they exist) on
mozilla.org.

Comment 2

[Mark Mentovai]

Attachment: Specify packaging attributes for localized builds

Comment 3

[Mark Mentovai]

Fixed on trunk.

Comment 4

[Mark Mentovai]

Nobody makes in other-licenses/branding/firefox or browser/app on the
repackaging machine, so the needed files aren't present in dist.  Backing out -
most likely solution is to extract the needed files during the unpack.

Comment 5

[Mark Mentovai]

Attachment: v2

This is the same as the previous version, but it creates $(DIST)/branding
before the unpackager runs.  The unpackager was modified in bug 305131 to pull
all of the needed resources out of the dmg.  There are further revisions to the
305131 patch here because () was creating subshells that weren't properly
communicating exit status, so it was possible for failures to clean up but not
halt the build (though not likely in the current configuration) - use {}
instead to hang on to exit status.

Comment 6

[Mark Mentovai]

Comment on attachment 193923 [details] [diff] [review]
v2

Fixed on trunk.

Comment 7

[Mark Mentovai]

This is now working on the trunk and (wow!) branch:

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla1.8-l10n-fr/1125087480.12036.gz&fulltext=1