305689 - [FIXr]Cache event queue service in nsContentUtils

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

This way we don't have to keep calling GetService on it and can stop caching it
in presshells.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

it'd be nice if nsContentUtils.h documented which functions guarantee a non-null
return and which don't...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Perhaps should simply use Foo() instead of GetFoo() for the ones that guarantee
non-null?

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to comment #3)
> Perhaps should simply use Foo() instead of GetFoo() for the ones that guarantee
> non-null?

Yeah, I think we should do that.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 193627 [details] [diff] [review]
Like so

>Index: content/base/src/nsImageLoadingContent.cpp
>===================================================================

>+#include "nsIEventStateManager.h"

Is this needed?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Is this needed?

No.  It snuck in from another patch.  I'll remove it and rename the method to
EventQueueService() when I check in.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to comments

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Fix leak

We should release too.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193828 [details] [diff] [review]
Fix leak

Doh... I suck.