305713 - SNAV - when page needs keyboard events, disable snav

Status: RESOLVED FIXED

(Minimo Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

As I understand this, there isn't anyway:

a) to know if a page has a keypress handler.
b) to create sIDOMKeyListener such that content gets the event before the
nsIDOMKeyListener.

In fact, you can set up a page which overrides every control sequence such that
all application menus are inaccessible via the keyboard.

I think the short term solution is to ensure that the keys that spatial
navigation use do not intersect much with the keys that webpages commonly use.  

Comment 2

[Aaron Leventhal]

Find as you type had to deal with this as well. We check to see if
preventDefault was called on the key event, and we make sure we get it after the
page. Many pages want to use alphanumeric keys for their own purposes.

Check typeaheadfind.cpp

Comment 3

[Doug Turner (:dougt)]

very cool!

Is this the code:
http://lxr.mozilla.org/seamonkey/source/extensions/typeaheadfind/src/nsTypeAheadFind.cpp#688


lets move this out of the dark hole know as future. tm=010

Comment 4

[Aaron Leventhal]

Yeah also look at
http://lxr.mozilla.org/seamonkey/source/extensions/typeaheadfind/src/nsTypeAheadFind.cpp#2334
There's also a method to remove the listeners.

We have to attach the keypress listener such that we get it at the right time.

Comment 5

[Doug Turner (:dougt)]

Fix checked in.  webapps that do not want to use the same keys as snav need to call e.preventDefault() on their keypress event.