305715 - missing sentinel build warning in nsFontMetricsPango.cpp

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

missing sentinel build warning in nsFontMetricsPango.cpp

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 193662 [details] [diff] [review]
patch

no risk for branch but this breaks our build because of paranoid compiler
checks

Comment 3

[Brendan Eich [:brendan]]

Should that be nsnull, not NULL?

/be

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

nsnull is defined as
#define nsnull 0
in nscore.h?

Then it shouldn't be nsnull because 0 was there before and gcc4 is complaining
about it being 0 instead of NULL.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Checking in ./gfx/src/gtk/nsFontMetricsPango.cpp;
/cvsroot/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp,v  <--  nsFontMetricsPango.cpp
new revision: 1.16.2.1; previous revision: 1.16
done

It seems gcc does only allow real "NULL" here.