Closed Bug 305715 Opened 14 years ago Closed 14 years ago
missing sentinel build warning in ns
Font Metrics Pango .cpp
missing sentinel build warning in nsFontMetricsPango.cpp
Comment on attachment 193662 [details] [diff] [review] patch no risk for branch but this breaks our build because of paranoid compiler checks
Attachment #193662 - Flags: approval1.8b4?
Attachment #193662 - Flags: approval1.8b4? → approval1.8b4+
Should that be nsnull, not NULL? /be
nsnull is defined as #define nsnull 0 in nscore.h? Then it shouldn't be nsnull because 0 was there before and gcc4 is complaining about it being 0 instead of NULL.
Checking in ./gfx/src/gtk/nsFontMetricsPango.cpp; /cvsroot/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp,v <-- nsFontMetricsPango.cpp new revision: 18.104.22.168; previous revision: 1.16 done It seems gcc does only allow real "NULL" here.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.