Closed Bug 305715 Opened 14 years ago Closed 14 years ago

missing sentinel build warning in nsFontMetricsPango.cpp

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: wolfiR)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

missing sentinel build warning in nsFontMetricsPango.cpp
Attached patch patchSplinter Review
Assignee: blizzard → mozilla
Status: NEW → ASSIGNED
Attachment #193662 - Flags: superreview?(roc)
Attachment #193662 - Flags: review?(caillon)
Attachment #193662 - Flags: superreview?(roc)
Attachment #193662 - Flags: superreview+
Attachment #193662 - Flags: review?(caillon)
Attachment #193662 - Flags: review+
Comment on attachment 193662 [details] [diff] [review]
patch

no risk for branch but this breaks our build because of paranoid compiler
checks
Attachment #193662 - Flags: approval1.8b4?
Attachment #193662 - Flags: approval1.8b4? → approval1.8b4+
Should that be nsnull, not NULL?

/be
Flags: blocking1.8b4+
nsnull is defined as
#define nsnull 0
in nscore.h?

Then it shouldn't be nsnull because 0 was there before and gcc4 is complaining
about it being 0 instead of NULL.
Checking in ./gfx/src/gtk/nsFontMetricsPango.cpp;
/cvsroot/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp,v  <--  nsFontMetricsPango.cpp
new revision: 1.16.2.1; previous revision: 1.16
done

It seems gcc does only allow real "NULL" here.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.