missing sentinel build warning in nsFontMetricsPango.cpp
Created attachment 193662 [details] [diff] [review] patch
Comment on attachment 193662 [details] [diff] [review] patch no risk for branch but this breaks our build because of paranoid compiler checks
Should that be nsnull, not NULL? /be
nsnull is defined as #define nsnull 0 in nscore.h? Then it shouldn't be nsnull because 0 was there before and gcc4 is complaining about it being 0 instead of NULL.
Checking in ./gfx/src/gtk/nsFontMetricsPango.cpp; /cvsroot/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp,v <-- nsFontMetricsPango.cpp new revision: 188.8.131.52; previous revision: 1.16 done It seems gcc does only allow real "NULL" here.