missing sentinel build warning in nsFontMetricsPango.cpp

RESOLVED FIXED

Status

Core Graveyard
GFX: Gtk
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: wolfiR, Assigned: wolfiR)

Tracking

(Blocks: 1 bug, {fixed1.8})

Trunk
x86
Linux
fixed1.8
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
missing sentinel build warning in nsFontMetricsPango.cpp
(Assignee)

Comment 1

12 years ago
Created attachment 193662 [details] [diff] [review]
patch
Assignee: blizzard → mozilla
Status: NEW → ASSIGNED
Attachment #193662 - Flags: superreview?(roc)
Attachment #193662 - Flags: review?(caillon)
Attachment #193662 - Flags: superreview?(roc)
Attachment #193662 - Flags: superreview+
Attachment #193662 - Flags: review?(caillon)
Attachment #193662 - Flags: review+
(Assignee)

Comment 2

12 years ago
Comment on attachment 193662 [details] [diff] [review]
patch

no risk for branch but this breaks our build because of paranoid compiler
checks
Attachment #193662 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #193662 - Flags: approval1.8b4? → approval1.8b4+
Should that be nsnull, not NULL?

/be
Flags: blocking1.8b4+
(Assignee)

Comment 4

12 years ago
nsnull is defined as
#define nsnull 0
in nscore.h?

Then it shouldn't be nsnull because 0 was there before and gcc4 is complaining
about it being 0 instead of NULL.
(Assignee)

Comment 5

12 years ago
Checking in ./gfx/src/gtk/nsFontMetricsPango.cpp;
/cvsroot/mozilla/gfx/src/gtk/nsFontMetricsPango.cpp,v  <--  nsFontMetricsPango.cpp
new revision: 1.16.2.1; previous revision: 1.16
done

It seems gcc does only allow real "NULL" here.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.