305722 - Invalid "To" date in New Task window when switching Item type from Task to Event

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Marcin Kost]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8b4) Gecko/20050818 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050823 Mozilla Sunbird/0.2+

'New task' window has an option to change the Item type from Task to Event. When
I choose to do so and then try to change the 'From' date, the 'To' date shows
"Invalid date" for both date and time. After that I can't do anything with the
window and it has to be closed by clicking 'Cancel'

Reproducible: Always

Steps to Reproduce:
1. Choose New task option
2. Change the Item type from Task to Event
3. Try to change the 'From' date

Actual Results:  
'To' date shows "Invalid date"

Expected Results:  
The 'To' date should show the 'From' date or the 'From' date + the given Task
duration time.

Comment 1

[Marcin Kost]

In addition, I can see following errors in the JavaScript Console:

Error: hourItem has no properties
Source File: chrome://calendar/content/datetimepickers/datetimepickers.xml
Line: 853

Error: [Exception... "Cannot modify properties of a WrappedNative"  nsresult:
"0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame ::
chrome://calendar/content/eventDialog.js :: onOKCommand :: line 484"  data: no]
Source File: chrome://calendar/content/eventDialog.js
Line: 484

Comment 2

[Joey Minta]

(In reply to comment #1)
> In addition, I can see following errors in the JavaScript Console:
> 
> Error: hourItem has no properties
> Source File: chrome://calendar/content/datetimepickers/datetimepickers.xml
> Line: 853

This seems to be caused by the fact that gDurationMSec isn't set.

> Error: [Exception... "Cannot modify properties of a WrappedNative"  nsresult:
> "0x80570034 (NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN)"  location: "JS frame ::
> chrome://calendar/content/eventDialog.js :: onOKCommand :: line 484"  data: no]
> Source File: chrome://calendar/content/eventDialog.js
> Line: 484

My guess here is that something is going wrong with the QI.

Status: New

Comment 3

[Michael Büttner (no reviews TFN)]

Since I can't imagine any reasonable use cases for this feature, I would suggest getting rid of it. Any objections?

Comment 4

[Joey Minta]

(In reply to comment #3)
> Since I can't imagine any reasonable use cases for this feature, I would
> suggest getting rid of it. Any objections?
> 
We have had several requests for it and I can see a couple possible cases:
1.) Accidentally clicking the wrong 'New' button (Choosing New Event instead of New Taske, or vice versa).  In fact, having this option would probably allow us to consolidate those options, making our menus simpler.

2.) Events that lead to tasks.  For example, if I'm taking the notes for our weekly meeting, when the meeting finishes, I have a task (post the notes).  Rather than writing a completely new task, I can simply flip the meeting to a task and my calendar is correct with a couple of clicks.

See also bug 277731, which generally outlines (1) and has 2 additional duplicates filed.

Note that those bugs also reference the ability to do this via drag-n-drop.  Were you talking about removing the menuitem or the entire backend possibility of this?

Comment 5

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 6

[Joey Minta]

Should be fixed by bug 277731.

Comment 7

[Martin Schröder [:mschroeder]]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070418 Calendar/0.5pre.